fix: rope_scaling unhashable dict error with transformers>=5.1.0#182
Open
chenwenxiaolive wants to merge 2 commits into
Open
fix: rope_scaling unhashable dict error with transformers>=5.1.0#182chenwenxiaolive wants to merge 2 commits into
chenwenxiaolive wants to merge 2 commits into
Conversation
Newer versions of transformers (>=5.1.0) initialize rope_scaling as a dict instead of None, which causes TypeError with @lru_cache since dicts are unhashable. Since RoPE scaling is not yet implemented, explicitly pass None to avoid the error. Fixes GeeeekExplorer#167 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
I think this param shall be processed instead of directly ignored... |
Author
|
@Seas0 Now handled rope_scaling explicitly instead of ignoring it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: unhashable type: 'dict'when using Qwen3 withtransformers>=5.1.0rope_scalingas a dict (e.g.{'rope_theta': 1000000, 'rope_type': 'default'}) instead ofNone, which breaks@lru_cacheinget_roperope_scaling=NoneinQwen3Attentionsince RoPE scaling is not yet implementedFixes #167
Test plan