Add typing for latest versions compatibility#96
Open
AlexKay28 wants to merge 1 commit into
Open
Conversation
Owner
|
It works if you use deepspeed==0.7.0 pytorch-lightning==1.9.2 please try :) |
Author
|
@BlinkDL yes, it works, i knew it :) But I noticed you don't provide in the project requirements.txt file or something + it might be not possible to install needed versions in some environments, so I decided to add this typing to avoid such kind of problems. Feel free to close this issue without applying changes if you think it's redundant, but I have seen some messages from people with this problem :/ I just thought it could make the code safer and that's it) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added explicit typing into "bf16" condition usage section.
I have seen a lot of messages in discord chats and struggled personally with this. This PR doesn't change anything in functionality, but just makes code more clear and friendly to the older versions of torch packages