Fix undefined symbol error in RWKV-7 l2wrap CUDA kernel (sync v2 kernels with v1 headers)#336
Open
A190nux wants to merge 1 commit into
Open
Fix undefined symbol error in RWKV-7 l2wrap CUDA kernel (sync v2 kernels with v1 headers)#336A190nux wants to merge 1 commit into
A190nux wants to merge 1 commit into
Conversation
Owner
|
Thank you :) I fixed it in latest version too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a build-breaking "undefined symbol" error encountered when compiling the custom CUDA operators for RWKV-7.
The Issue
The C++ wrapper (rwkv7_l2wrap_ce_bf16_v1.cpp) expects forward and backward function names suffixed with _v1_cuda. However, the corresponding CUDA implementation (rwkv7_l2wrap_ce_bf16_v1.cu) defined these functions as _v2_cuda. This mismatch prevented the linker from finding the required symbols during the JIT compilation process.
Changes
Validation
Verified that the training script demo-training-prepare-v7-pile.sh now compiles the extensions successfully using ninja and proceeds to model initialization and training without symbol errors.