This repository was archived by the owner on Aug 1, 2024. It is now read-only.
adding constructor for oauth token + account name#912
Open
markjgardner wants to merge 1 commit into
Open
Conversation
Author
|
@seanmcc-msft and @kfarmer-msft would either of you mind taking a look at this PR? |
seanmcc-msft
approved these changes
Jul 31, 2019
Author
|
@seanmcc-msft any chance this will actually get merged any time soon? |
Author
|
@seanmcc-msft pretty please? I have a few downstream changes that I can't submit until this issue is addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the prolific use of credentials.AccountName throughout the Azure SDKs, it would be really useful if we could set the account name when using AAD auth (instead of SAS or shared key).