views: Show author name in EditHistoryView.

This adds get_author, a method that gets the author's full name in
constant time/O(1), to show the author's full name in EditHistoryView.

In addition to that, a minimal author_prefix ('Posted' and 'Edited') has
also been added.

Test added and amended.

O(1)-lookup-suggested-by: Sumanth V Rao <[email protected]>

Author: preetmishra

tests/ui/test_ui_tools.py

@@ -1242,13 +1242,15 @@ def test_keypress_navigation(self, mocker,
 class TestEditHistoryView:
     @pytest.fixture(autouse=True)
     def mock_external_classes(self, mocker, message_fixture,
-                              message_history_fixture):
+                              message_history_fixture, user_dict):
         self.controller = mocker.Mock()
         mocker.patch.object(self.controller, 'maximum_popup_dimensions',
                             return_value=(64, 64))
         self.controller.model.get_message_history = (
             mocker.Mock(return_value='')
         )
+        self.controller.model.user_id_email_dict = {1001: '[email protected]'}
+        self.controller.model.user_dict = user_dict
         message_fixture['message_history'] = message_history_fixture
         mocker.patch(VIEWS + '.urwid.SimpleFocusListWalker', return_value=[])
         self.edit_history_view = EditHistoryView(self.controller,
@@ -1261,6 +1263,11 @@ def test_init(self, mocker, message_fixture):
         (self.controller.model.get_message_history.
          assert_called_once_with(message_fixture))
 
+    @pytest.mark.parametrize('user_id, full_name', [(1001, 'Human Myself')])
+    def test_get_author(self, user_id, full_name):
+        result = self.edit_history_view.get_author(user_id)
+        assert result == full_name
+
     @pytest.mark.parametrize('key', keys_for_command('MSG_INFO'))
     def test_keypress_exit_popup(self, key):
         size = (200, 20)
@@ -1295,7 +1302,8 @@ def test_edit_block(self, message_history_fixture):
             assert isinstance(contents[0][0], Text)  # Header: Topic.
             assert isinstance(contents[0][1], Text)  # Header: Timestamp.
             assert isinstance(contents[1], Columns)  # Subheader.
-            assert isinstance(contents[1][0], Text)  # Subheader: Tag.
+            assert isinstance(contents[1][0], Text)  # Subheader: Author.
+            assert isinstance(contents[1][1], Text)  # Subheader: Tag.
             assert isinstance(contents[2], Text)     # Content.
 
 

zulipterminal/ui_tools/views.py

@@ -1018,13 +1018,18 @@ def edit_block(self, snapshot: Dict[str, Any], state: str) -> Any:
 
         tag = '({} Version)'.format(state) if state else ''
 
+        author_prefix = 'Posted' if state == 'Original' else 'Edited'
+        author = '{} by {}'.format(author_prefix,
+                                   self.get_author(snapshot['user_id']))
+
         header = [
             urwid.Text(('edit_topic', topic)),
             (19, urwid.Text(('edit_time', timestamp))),  # 19 = len(timestamp).
         ]
         subheader = [
+            urwid.Text(('edit_author', author)),
             # 18 = max(len(tag)); len('(Original Version)').
-            (18, urwid.Text(('edit_tag', tag))),
+            (18, urwid.Text(('edit_tag', tag), align='right')),
         ]
 
         edit_block = [
@@ -1035,6 +1040,11 @@ def edit_block(self, snapshot: Dict[str, Any], state: str) -> Any:
         ]
         return urwid.Pile(edit_block)
 
+    def get_author(self, user_id: int) -> str:
+        user_email = self.controller.model.user_id_email_dict[user_id]
+        full_name = self.controller.model.user_dict[user_email]['full_name']
+        return full_name
+
     def keypress(self, size: urwid_Size, key: str) -> str:
         if (is_command_key('GO_BACK', key)
                 or is_command_key('EDIT_HISTORY', key)):