views/core: Add search logic and full emoji list to EmojiPickerView.

This commit completes the logic of searching for emojis from the
EmojiPickerView on pressing 'p' key. The search is kept dynamic
for faster reacting to messages.

The emoji list now also displays the full list of emoji's present
in model.active_emoji_data. A few bugs related to displaying empty
emoji list and searching in general have also been fixed.

Tests added and amended.

Author: zee-bit

tests/ui_tools/test_popups.py

@@ -1316,6 +1316,51 @@ def mock_external_classes(self, mocker, message_fixture):
             self.view,
         )
 
+    @pytest.mark.parametrize(
+        "emoji_units",
+        [
+            (
+                ("action", "1f3ac", []),
+                ("alien", "1f47d", ["ufo"]),
+                ("angel", "1f47c", []),
+                ("anger", "1f4a2", ["bam", "pow"]),
+                ("angry", "1f620", []),
+                ("eight", "0038-20e3", []),
+                ("email", "2709", ["envelope", "mail"]),
+                ("eye", "1f441", []),
+                ("ball", "26f9", ["sports"]),
+                ("cat", "1f408", ["meow"]),
+                ("heart", "2764", ["love", "love_you"]),
+                ("lightning", "1f329", ["lightning_storm"]),
+                ("smile", "1f642", []),
+                ("smiley", "1f603", []),
+                ("smirk", "1f60f", ["smug"]),
+                ("smoking", "1f6ac", []),
+            )
+        ],
+    )
+    @pytest.mark.parametrize(
+        ["search_string", "assert_list"],
+        [
+            ("e", ["eight", "email", "eye"]),
+            ("sm", ["smile", "smiley", "smirk", "smoking"]),
+            ("ang", ["angel", "anger", "angry"]),
+            ("abc", []),
+            ("q", []),
+        ],
+    )
+    def test_update_emoji_list(self, emoji_units, search_string, assert_list):
+        self.emoji_picker_view.emoji_buttons = (
+            self.emoji_picker_view.generate_emoji_buttons(emoji_units)
+        )
+
+        self.emoji_picker_view.update_emoji_list("SEARCH_EMOJIS", search_string)
+        self.emojis_display = self.emoji_picker_view.emojis_display
+        emojis_display_name = [emoji.emoji_name for emoji in self.emojis_display]
+
+        assert emojis_display_name == assert_list
+        assert self.emoji_picker_view.get_focus() == "header"
+
     @pytest.mark.parametrize("key", keys_for_command("SEARCH_EMOJIS"))
     def test_keypress_search_emoji(self, key, widget_size):
         size = widget_size(self.emoji_picker_view)

zulipterminal/core.py

@@ -277,12 +277,12 @@ def show_msg_info(
         self.show_pop_up(msg_info_view, "area:msg")
 
     def show_emoji_picker(self, message: Message) -> None:
+        all_emoji_units = [
+            (emoji_name, emoji["code"], emoji["aliases"])
+            for emoji_name, emoji in self.model.active_emoji_data.items()
+        ]
         emoji_picker_view = EmojiPickerView(
-            self,
-            "Add/Remove Emojis",
-            [("+1", "1f44d", ["thumbs_up", "like"])],
-            message,
-            self.view,
+            self, "Add/Remove Emojis", all_emoji_units, message, self.view
         )
         self.show_pop_up(emoji_picker_view, "area:msg")
 

zulipterminal/ui_tools/views.py

@@ -34,6 +34,7 @@
     Message,
     TidiedUserInfo,
     asynch,
+    match_emoji,
     match_stream,
     match_user,
 )
@@ -1922,8 +1923,8 @@ def __init__(
         self.message = message
         self.controller = controller
         self.selected_emojis: Dict[str, str] = {}
-        emoji_buttons = self.generate_emoji_buttons(emoji_units)
-        width = max(len(button.label) for button in emoji_buttons)
+        self.emoji_buttons = self.generate_emoji_buttons(emoji_units)
+        width = max(len(button.label) for button in self.emoji_buttons)
         max_cols, max_rows = controller.maximum_popup_dimensions()
         popup_width = min(max_cols, width)
         self.emoji_search = PanelSearchBox(
@@ -1941,9 +1942,10 @@ def __init__(
             brcorner="─",
         )
         self.empty_search = False
+        self.search_lock = threading.Lock()
         super().__init__(
             controller,
-            emoji_buttons,
+            self.emoji_buttons,
             "ADD_REACTION",
             popup_width,
             title,
@@ -1959,7 +1961,43 @@ def update_emoji_list(
         new_text: Optional[str] = None,
         emoji_list: Any = None,
     ) -> None:
-        pass
+        """
+        Updates emoji list via PanelSearchBox.
+        """
+        assert (emoji_list is None and search_box is not None) or (
+            emoji_list is not None and search_box is None and new_text is None
+        )
+
+        # Return if the method is called by PanelSearchBox without
+        # self.emoji_search being defined.
+        if not hasattr(self, "emoji_search"):
+            return
+
+        with self.search_lock:
+            self.emojis_display = list()
+            if new_text and new_text != self.emoji_search.search_text:
+                for button in self.emoji_buttons:
+                    if match_emoji(button.emoji_name, new_text):
+                        self.emojis_display.append(button)
+                    else:
+                        for alias in button.aliases:
+                            if match_emoji(alias, new_text):
+                                self.emojis_display.append(button)
+                                break
+            else:
+                self.emojis_display = self.emoji_buttons
+
+            self.empty_search = len(self.emojis_display) == 0
+
+            body_content = self.emojis_display
+            if self.empty_search:
+                body_content = [self.emoji_search.search_error]
+
+            self.contents["body"] = (
+                urwid.ListBox(urwid.SimpleFocusListWalker(body_content)),
+                None,
+            )
+            self.controller.update_screen()
 
     def is_selected_emoji(self, emoji_name: str) -> bool:
         return emoji_name in self.selected_emojis.values()