refactor: model/boxes: Store emoji data in model.

Save the data from emoji_data.py as a model attribute, instead of
loading them directly from the file.

This will make it easy, in the future, to use emoji data when it is
fetched from different sources, for example - custom emojis that will
be fetched using a server endpoint.

Tests amended.

Author: kaustubh-nair

tests/model/test_model.py

@@ -24,7 +24,8 @@ def mock_external_classes(self, mocker: Any) -> None:
                             'zulipterminal.model.display_error_if_present')
 
     @pytest.fixture
-    def model(self, mocker, initial_data, user_profile):
+    def model(self, mocker, initial_data, user_profile,
+              unicode_emojis):
         mocker.patch('zulipterminal.model.Model.get_messages',
                      return_value='')
         self.client.register.return_value = initial_data
@@ -38,10 +39,13 @@ def model(self, mocker, initial_data, user_profile):
             'zulipterminal.model.classify_unread_counts',
             return_value=[])
         self.client.get_profile.return_value = user_profile
+        mocker.patch('zulipterminal.model.emoji_data',
+                     EMOJI_DATA=unicode_emojis)
         model = Model(self.controller)
         return model
 
-    def test_init(self, model, initial_data, user_profile):
+    def test_init(self, model, initial_data, user_profile,
+                  unicode_emojis):
         assert hasattr(model, 'controller')
         assert hasattr(model, 'client')
         assert model.narrow == []
@@ -71,6 +75,7 @@ def test_init(self, model, initial_data, user_profile):
         assert model.unpinned_streams == []
         self.classify_unread_counts.assert_called_once_with(model)
         assert model.unread_counts == []
+        assert model.emoji_data == unicode_emojis
 
     def test_init_InvalidAPIKey_response(self, mocker, initial_data):
         # Both network calls indicate the same response

tests/ui_tools/test_boxes.py

@@ -16,6 +16,8 @@ def mock_external_classes(self, mocker, initial_index):
     @pytest.fixture()
     def write_box(self, mocker, users_fixture, user_groups_fixture,
                   streams_fixture, unicode_emojis):
+        self.view.model.emoji_data = unicode_emojis
+
         write_box = WriteBox(self.view)
         write_box.view.users = users_fixture
         write_box.model.user_group_names = [
@@ -26,8 +28,6 @@ def write_box(self, mocker, users_fixture, user_groups_fixture,
             [stream['name']] for stream in
             streams_fixture], key=lambda stream: stream[0].lower())
 
-        mocker.patch('zulipterminal.ui_tools.boxes.emoji_data',
-                     EMOJI_DATA=unicode_emojis)
         return write_box
 
     def test_init(self, write_box):

zulipterminal/model.py

@@ -11,6 +11,7 @@
 import zulip
 from mypy_extensions import TypedDict
 
+from zulipterminal import emoji_data
 from zulipterminal.config.keys import keys_for_command
 from zulipterminal.helper import (
     Message, asynch, canonicalize_color, classify_unread_counts,
@@ -125,6 +126,8 @@ def __init__(self, controller: Any) -> None:
 
         self.unread_counts = classify_unread_counts(self)
 
+        self.emoji_data = emoji_data.EMOJI_DATA
+
         self.new_user_input = True
         self._start_presence_updates()
 

zulipterminal/ui_tools/boxes.py

@@ -10,7 +10,6 @@
 from bs4.element import NavigableString
 from urwid_readline import ReadlineEdit
 
-from zulipterminal import emoji_data
 from zulipterminal.config.keys import is_command_key, keys_for_command
 from zulipterminal.config.symbols import (
     MESSAGE_CONTENT_MARKER, MESSAGE_HEADER_DIVIDER, QUOTED_TEXT_MARKER,
@@ -197,7 +196,7 @@ def autocomplete_streams(self, text: str, prefix_string: str
 
     def autocomplete_emojis(self, text: str, prefix_string: str
                             ) -> Tuple[List[str], List[str]]:
-        emoji_list = list(emoji_data.EMOJI_DATA.keys())
+        emoji_list = list(self.model.emoji_data.keys())
         emojis = [emoji
                   for emoji in emoji_list
                   if match_emoji(emoji, text[1:])]