bugfix: model: Fix repeat register issue, allowing successful reconnect.

This bug was likely introduced in 75650da when the return type was
inverted and this calling site was not updated.

Test added.

Author: neiljp

tests/model/test_model.py

@@ -2017,3 +2017,25 @@ def test_poll_for_events__no_disconnect(self, mocker, model,
         assert not model._register_desired_events.called
         assert self.client.get_events.called
         assert not sleep.called
+
+    def test_poll_for_events__reconnect_ok(self, mocker, model, raising_event):
+        register_return_value = lambda: ""
+        mocker.patch("zulipterminal.model.Model._register_desired_events",
+                     side_effect=register_return_value)
+        sleep = mocker.patch("zulipterminal.model.time.sleep")
+
+        self.client.get_events.side_effect = [
+            {
+                "events": [raising_event],
+                "result": "success",
+            }
+        ]
+
+        model.queue_id = None  # Initial trigger for reconnecting
+
+        with pytest.raises(self.LoopEnder):
+            model.poll_for_events()
+
+        model._register_desired_events.assert_called_once()
+        assert self.client.get_events.called
+        assert not sleep.called

zulipterminal/model.py

@@ -1198,7 +1198,7 @@ def poll_for_events(self) -> None:
         while True:
             if queue_id is None:
                 while True:
-                    if self._register_desired_events():
+                    if not self._register_desired_events():
                         queue_id = self.queue_id
                         last_event_id = self.last_event_id
                         break