model: Highlight stream name in reporting of moving/spliting topics.

Partially fixes #1172

Author: srdeotarse

tests/helper/test_helper.py

@@ -431,7 +431,9 @@ def test_notify_if_message_sent_outside_narrow(
     if footer_updated:
         key = primary_key_for_command("NARROW_MESSAGE_RECIPIENT")
         report_success.assert_called_once_with(
-            [f"Message is sent outside of current narrow. Press [{key}] to narrow to conversation."],
+            [
+                f"Message is sent outside of current narrow. Press [{key}] to narrow to conversation."
+            ],
             duration=6,
         )
     else:

tests/model/test_model.py

@@ -7,6 +7,7 @@
 from pytest import param as case
 from zulip import Client, ZulipError
 
+from zulipterminal.config.symbols import STREAM_TOPIC_SEPARATOR
 from zulipterminal.helper import initial_index, powerset
 from zulipterminal.model import (
     MAX_MESSAGE_LENGTH,
@@ -854,7 +855,13 @@ def test_update_private_message(
                 },
                 "Old topic",
                 [
-                    "You changed one message's topic from #stream > Old topic to #stream > Topic change."
+                    "You changed one message's topic from ",
+                    ("footer_contrast", f" stream {STREAM_TOPIC_SEPARATOR} "),
+                    ("footer_contrast", " Old topic "),
+                    " to ",
+                    ("footer_contrast", f" stream {STREAM_TOPIC_SEPARATOR} "),
+                    ("footer_contrast", " Topic change "),
+                    " .",
                 ],
             ),
             case(
@@ -885,7 +892,13 @@ def test_update_private_message(
                 },
                 "old_terminal",
                 [
-                    "You changed some messages' topic from #stream > old_terminal to #stream > new_terminal."
+                    "You changed some messages' topic from ",
+                    ("footer_contrast", f" stream {STREAM_TOPIC_SEPARATOR} "),
+                    ("footer_contrast", " old_terminal "),
+                    " to ",
+                    ("footer_contrast", f" stream {STREAM_TOPIC_SEPARATOR} "),
+                    ("footer_contrast", " new_terminal "),
+                    " .",
                 ],
             ),
             case(
@@ -897,7 +910,13 @@ def test_update_private_message(
                 },
                 "greet",
                 [
-                    "You changed one message's topic from #stream > greet to #stream > grett."
+                    "You changed one message's topic from ",
+                    ("footer_contrast", f" stream {STREAM_TOPIC_SEPARATOR} "),
+                    ("footer_contrast", " greet "),
+                    " to ",
+                    ("footer_contrast", f" stream {STREAM_TOPIC_SEPARATOR} "),
+                    ("footer_contrast", " grett "),
+                    " .",
                 ],
             ),
             case(
@@ -909,7 +928,13 @@ def test_update_private_message(
                 },
                 "lets_party",
                 [
-                    "You changed all messages' topic from #stream > lets_party to #stream > party."
+                    "You changed all messages' topic from ",
+                    ("footer_contrast", f" stream {STREAM_TOPIC_SEPARATOR} "),
+                    ("footer_contrast", " lets_party "),
+                    " to ",
+                    ("footer_contrast", f" stream {STREAM_TOPIC_SEPARATOR} "),
+                    ("footer_contrast", " party "),
+                    " .",
                 ],
             ),
         ],

zulipterminal/helper.py

@@ -656,7 +656,9 @@ def check_narrow_and_notify(
         key = primary_key_for_command("NARROW_MESSAGE_RECIPIENT")
 
         controller.report_success(
-            [f"Message is sent outside of current narrow. Press [{key}] to narrow to conversation."],
+            [
+                f"Message is sent outside of current narrow. Press [{key}] to narrow to conversation."
+            ],
             duration=6,
         )
 

zulipterminal/model.py

@@ -36,6 +36,7 @@
     Subscription,
 )
 from zulipterminal.config.keys import primary_key_for_command
+from zulipterminal.config.symbols import STREAM_TOPIC_SEPARATOR
 from zulipterminal.config.ui_mappings import ROLE_BY_ID, StreamAccessType
 from zulipterminal.helper import (
     Message,
@@ -580,7 +581,12 @@ def update_stream_message(
             stream_name = message.get("display_recipient", None)
             old_topic = message.get("subject", None)
             new_topic = request["topic"]
-
+            stream_name_markup = (
+                "footer_contrast",
+                f" {stream_name} {STREAM_TOPIC_SEPARATOR} ",
+            )
+            old_topic_markup = ("footer_contrast", f" {old_topic} ")
+            new_topic_markup = ("footer_contrast", f" {new_topic} ")
             if old_topic != new_topic:
                 if propagate_mode == "change_one":
                     messages_changed = "one message's"
@@ -590,9 +596,13 @@ def update_stream_message(
                     messages_changed = "some messages'"
                 self.controller.report_success(
                     [
-                        f"You changed {messages_changed} topic"
-                        + f" from #{stream_name} > {old_topic}"
-                        + f" to #{stream_name} > {new_topic}."
+                        f"You changed {messages_changed} topic from ",
+                        stream_name_markup,
+                        old_topic_markup,
+                        " to ",
+                        stream_name_markup,
+                        new_topic_markup,
+                        " .",
                     ],
                     duration=6,
                 )