core/themes: Add title color styling; Add Category-wise colors.

This commit adds:
 * color-per-category for each popup box
 * A sementic option in show_pop_up function call

The categories as of now are help, error, message and stream.

Fixes #684.

Author: Ezio-Sarthak

zulipterminal/config/themes.py

@@ -44,7 +44,10 @@
     'edit_author': 'bold',
     'edit_time': 'bold',
     'popup_border': 'standout',
-    'popup_title': 'bold',
+    'area:help': 'standout',
+    'area:msg': 'standout',
+    'area:stream': 'standout',
+    'area:error': 'standout',
 }
 
 
@@ -173,10 +176,16 @@
          None,             DEF['white'],              DEF['black']),
         ('muted',          'light blue',              'black',
          None,             DEF['light_blue'],         DEF['black']),
-        ('popup_title',    'black',                   'white',
-         None,             DEF['black'],              DEF['white']),
         ('popup_border',   'white',                   'black',
          None,             DEF['white'],              DEF['black']),
+        ('area:help',      'white',                   'dark green',
+         None,             DEF['white'],              DEF['dark_green']),
+        ('area:msg',       'white',                   'brown',
+         None,             DEF['white'],              DEF['brown']),
+        ('area:stream',    'white',                   'dark cyan',
+         None,             DEF['white'],              DEF['dark_cyan']),
+        ('area:error',     'white',                   'dark red',
+         None,             DEF['white'],               DEF['dark_red']),
     ],
     'gruvbox_dark': [
         # default colorscheme on 16 colors, gruvbox colorscheme
@@ -257,10 +266,16 @@
          None,             WHITE,             BLACK),
         ('muted',          'light blue',      'black',
          None,             LIGHTBLUE,         BLACK),
-        ('popup_title',    'black',           'white',
-         None,             BLACK,             WHITE),
         ('popup_border',   'white',           'black',
          None,             WHITE,             BLACK),
+        ('area:help',      'black',           'light green',
+         None,             BLACK,             LIGHTGREEN),
+        ('area:msg',       'black',           'light red',
+         None,             BLACK,             LIGHTRED),
+        ('area:stream',    'black',           'light blue',
+         None,             BLACK,             LIGHTBLUE),
+        ('area:error',     'white',           'dark red',
+         None,             WHITE,             DARKRED),
     ],
     'zt_light': [
         (None,             'black',           'white'),
@@ -301,8 +316,11 @@
         ('edit_time',      'dark blue',       'white'),
         ('current_user',   'dark gray',       'white'),
         ('muted',          'dark gray',       'white'),
-        ('popup_title',    'white',           'black'),
         ('popup_border',   'black',           'white'),
+        ('area:help',      'white',           'dark green'),
+        ('area:stream',    'white',           'dark cyan'),
+        ('area:msg',       'white',           'brown'),
+        ('area:error',     'white',           'dark red'),
     ],
     'zt_blue': [
         (None,             'black',           'light blue'),
@@ -343,8 +361,11 @@
         ('edit_time',      'dark blue',       'light blue'),
         ('current_user',   'light gray',      'light blue'),
         ('muted',          'light gray',      'light blue'),
-        ('popup_title',    'light blue',      'white'),
         ('popup_border',   'white',           'light blue'),
+        ('area:help',      'white',           'dark green'),
+        ('area:stream',    'white',           'dark cyan'),
+        ('area:msg',       'white',           'brown'),
+        ('area:error',     'white',           'dark red'),
     ]
 }  # type: Dict[str, ThemeSpec]
 

zulipterminal/core.py

@@ -161,18 +161,18 @@ def maximum_popup_dimensions(self) -> Tuple[int, int]:
                                  self.loop.screen.get_cols_rows())
         return max_cols, max_rows
 
-    def show_pop_up(self, to_show: Any) -> None:
+    def show_pop_up(self, to_show: Any, category: str) -> None:
         border_lines = dict(tlcorner='▛', tline='▀', trcorner='▜',
                             rline='▐', lline='▌',
                             blcorner='▙', bline='▄', brcorner='▟')
         text = urwid.Text(to_show.title, align='center')
-        title_map = urwid.AttrMap(urwid.Filler(text), 'popup_title')
+        title_map = urwid.AttrMap(urwid.Filler(text), category)
         title_box_adapter = urwid.BoxAdapter(title_map, height=1)
         title_box = urwid.LineBox(
             title_box_adapter, tlcorner='▀', tline='▀', trcorner='▀',
             rline='', lline='', blcorner='', bline='', brcorner=''
         )
-        title = urwid.AttrMap(title_box, 'popup_title')
+        title = urwid.AttrMap(title_box, category)
         content = urwid.LineBox(to_show, **border_lines)
         self.loop.widget = urwid.Overlay(
             urwid.AttrMap(urwid.Frame(header=title, body=content),
@@ -191,10 +191,10 @@ def exit_popup(self) -> None:
 
     def show_help(self) -> None:
         help_view = HelpView(self, "Help Menu (up/down scrolls)")
-        self.show_pop_up(help_view)
+        self.show_pop_up(help_view, 'area:help')
 
     def show_topic_edit_mode(self, button: Any) -> None:
-        self.show_pop_up(EditModeView(self, button))
+        self.show_pop_up(EditModeView(self, button), 'area:msg')
 
     def show_msg_info(self, msg: Message,
                       message_links: 'OrderedDict[str, Tuple[str, int, bool]]',
@@ -203,14 +203,15 @@ def show_msg_info(self, msg: Message,
         msg_info_view = MsgInfoView(self, msg,
                                     "Message Information (up/down scrolls)",
                                     message_links, time_mentions)
-        self.show_pop_up(msg_info_view)
+        self.show_pop_up(msg_info_view, 'area:msg')
 
     def show_stream_info(self, stream_id: int) -> None:
         show_stream_view = StreamInfoView(self, stream_id)
-        self.show_pop_up(show_stream_view)
+        self.show_pop_up(show_stream_view, 'area:stream')
 
     def popup_with_message(self, text: str, width: int) -> None:
-        self.show_pop_up(NoticeView(self, text, width, "NOTICE"))
+        self.show_pop_up(NoticeView(self, text, width, "NOTICE"),
+                         'area:error')
 
     def show_about(self) -> None:
         self.show_pop_up(
@@ -219,7 +220,8 @@ def show_about(self) -> None:
                       server_feature_level=self.model.server_feature_level,
                       theme_name=self.theme_name, color_depth=self.color_depth,
                       autohide_enabled=self.autohide,
-                      footlink_enabled=self.footlinks_enabled)
+                      footlink_enabled=self.footlinks_enabled),
+            'area:help'
         )
 
     def show_edit_history(
@@ -229,7 +231,8 @@ def show_edit_history(
     ) -> None:
         self.show_pop_up(
             EditHistoryView(self, message, message_links, time_mentions,
-                            'Edit History (up/down scrolls)')
+                            'Edit History (up/down scrolls)'),
+            'area:msg'
         )
 
     def search_messages(self, text: str) -> None: