From a529d013603893a6f3e331678bd402948ab82b5e Mon Sep 17 00:00:00 2001 From: Gp2mv3 Date: Wed, 1 Aug 2018 23:22:29 +0200 Subject: [PATCH 1/2] Fix requestPermission crash --- .../modules/RNPushNotification.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotification.java b/android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotification.java index 453033c97..5ee05891c 100644 --- a/android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotification.java +++ b/android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotification.java @@ -130,8 +130,12 @@ public void requestPermissions(String senderID) { Intent GCMService = new Intent(reactContext, RNPushNotificationRegistrationService.class); - GCMService.putExtra("senderID", senderID); - reactContext.startService(GCMService); + try { + GCMService.putExtra("senderID", senderID); + reactContext.startService(GCMService); + } catch (Exception e) { + Log.d("EXCEPTION SERVICE::::::", "requestPermissions: " + e); + } } @ReactMethod From 2c4fcc9cb6d19e9ece1888a9bbbbc61b9bcd81b1 Mon Sep 17 00:00:00 2001 From: Logan Date: Thu, 2 Aug 2018 15:28:19 -0400 Subject: [PATCH 2/2] Add import for symbol Log --- .../reactnativepushnotification/modules/RNPushNotification.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotification.java b/android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotification.java index 5ee05891c..c0bfb3a66 100644 --- a/android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotification.java +++ b/android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotification.java @@ -26,6 +26,8 @@ import java.util.Map; import java.util.Random; +import android.util.Log; + import com.google.firebase.messaging.FirebaseMessaging; public class RNPushNotification extends ReactContextBaseJavaModule implements ActivityEventListener {