update eslint-plugin-regexp

Author: zloirock

.eslintrc.js

@@ -474,20 +474,22 @@ const base = {
   'regexp/match-any': ['error', { allows: ['[\\S\\s]', 'dotAll'] }],
   // enforce use of escapes on negation
   'regexp/negation': 'error',
-  // disallow capturing group that captures assertions
-  'regexp/no-assertion-capturing-group': 'error',
   // disallow duplicate characters in the RegExp character class
   'regexp/no-dupe-characters-character-class': 'error',
   // disallow duplicate disjunctions
   'regexp/no-dupe-disjunctions': ['error', { report: 'all' }],
   // disallow alternatives without elements
   'regexp/no-empty-alternative': 'error',
+  // disallow capturing group that captures empty
+  'regexp/no-empty-capturing-group': 'error',
   // disallow empty group
   'regexp/no-empty-group': 'error',
   // disallow empty lookahead assertion or empty lookbehind assertion
   'regexp/no-empty-lookarounds-assertion': 'error',
   // disallow escape backspace `([\b])`
   'regexp/no-escape-backspace': 'error',
+  // disallow invalid regular expression strings in RegExp constructors
+  'regexp/no-invalid-regexp': 'error',
   // disallow invisible raw character
   'regexp/no-invisible-character': 'error',
   // disallow lazy quantifiers at the end of an expression
@@ -526,10 +528,10 @@ const base = {
   'regexp/no-useless-escape': 'error',
   // disallow unnecessary regex flags
   'regexp/no-useless-flag': 'error',
+  //  disallow unnecessarily non-greedy quantifiers
+  'regexp/no-useless-lazy': 'error',
   // disallow unnecessary non-capturing group
   'regexp/no-useless-non-capturing-group': 'error',
-  // disallow unnecessary quantifier non-greedy (`?`)
-  'regexp/no-useless-non-greedy': 'error',
   // disallow quantifiers that can be removed
   'regexp/no-useless-quantifier': 'error',
   // disallow unnecessary range of characters by using a hyphen
@@ -542,8 +544,6 @@ const base = {
   'regexp/optimal-quantifier-concatenation': 'error',
   // disallow the alternatives of lookarounds that end with a non-constant quantifier
   'regexp/optimal-lookaround-quantifier': 'error',
-  // enforces elements order in character class
-  'regexp/order-in-character-class': 'error',
   // enforce using character class
   'regexp/prefer-character-class': 'error',
   // enforce using `\d`
@@ -570,6 +570,8 @@ const base = {
   'regexp/prefer-w': 'error',
   // sort alternatives if order doesn't matter
   'regexp/sort-alternatives': 'error',
+  // enforces elements order in character class
+  'regexp/sort-character-class-elements': 'error',
   // require regex flags to be sorted
   'regexp/sort-flags': 'error',
   // disallow not strictly valid regular expressions

package.json

@@ -42,7 +42,7 @@
     "eslint-plugin-jsonc": "^1.4.0",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-qunit": "^6.2.0",
-    "eslint-plugin-regexp": "~0.13.2",
+    "eslint-plugin-regexp": "^1.0.0",
     "eslint-plugin-sonarjs": "~0.10.0",
     "eslint-plugin-unicorn": "^35.0.0",
     "jsonc-eslint-parser": "^1.1.0",

packages/core-js/internals/engine-is-ios-pebble.js

@@ -1,4 +1,4 @@
 var userAgent = require('../internals/engine-user-agent');
 var global = require('../internals/global');
 
-module.exports = /iphone|ipod|ipad/i.test(userAgent) && global.Pebble !== undefined;
+module.exports = /ipad|iphone|ipod/i.test(userAgent) && global.Pebble !== undefined;

packages/core-js/internals/engine-is-ios.js

@@ -1,3 +1,3 @@
 var userAgent = require('../internals/engine-user-agent');
 
-module.exports = /(?:iphone|ipod|ipad).*applewebkit/i.test(userAgent);
+module.exports = /(?:ipad|iphone|ipod).*applewebkit/i.test(userAgent);

packages/core-js/internals/regexp-exec.js

@@ -1,5 +1,5 @@
 'use strict';
-/* eslint-disable regexp/no-assertion-capturing-group, regexp/no-empty-group, regexp/no-lazy-ends -- testing */
+/* eslint-disable regexp/no-empty-capturing-group, regexp/no-empty-group, regexp/no-lazy-ends -- testing */
 /* eslint-disable regexp/no-useless-quantifier -- testing */
 var toString = require('../internals/to-string');
 var regexpFlags = require('../internals/regexp-flags');

packages/core-js/modules/es.string.replace.js

@@ -41,6 +41,7 @@ var REPLACE_SUPPORTS_NAMED_GROUPS = !fails(function () {
     result.groups = { a: '7' };
     return result;
   };
+  // eslint-disable-next-line regexp/no-useless-dollar-replacements -- false positive
   return ''.replace(re, '$<a>') !== '7';
 });
 

packages/core-js/modules/es.string.split.js

@@ -37,7 +37,7 @@ fixRegExpWellKnownSymbolLogic('split', function (SPLIT, nativeSplit, maybeCallNa
     'test'.split(/(?:)/, -1).length != 4 ||
     'ab'.split(/(?:ab)*/).length != 2 ||
     '.'.split(/(.?)(.?)/).length != 4 ||
-    // eslint-disable-next-line regexp/no-assertion-capturing-group, regexp/no-empty-group -- required for testing
+    // eslint-disable-next-line regexp/no-empty-capturing-group, regexp/no-empty-group -- required for testing
     '.'.split(/()()/).length > 1 ||
     ''.split(/.?/).length
   ) {

scripts/check-dependencies.mjs

@@ -13,7 +13,7 @@ await Promise.all((await globby(['package.json', 'packages/*/package.json'])).ma
   Object.assign(dependencies, devDependencies);
   for (const name of Object.keys(dependencies)) {
     const { required, stable, warn } = dependencies[name];
-    if (/^(?:git|file)/.test(required) || warn || eq(minVersion(required), coerce(stable))) {
+    if (/^(?:file|git)/.test(required) || warn || eq(minVersion(required), coerce(stable))) {
       delete dependencies[name];
     }
   }

tests/compat/tests.js

@@ -1,4 +1,4 @@
-/* eslint-disable radix, regexp/no-assertion-capturing-group, regexp/no-lazy-ends, regexp/no-useless-quantifier -- required for testing */
+/* eslint-disable radix, regexp/no-empty-capturing-group, regexp/no-lazy-ends, regexp/no-useless-quantifier -- required for testing */
 var GLOBAL = Function('return this')();
 var WHITESPACES = '\u0009\u000A\u000B\u000C\u000D\u0020\u00A0\u1680\u2000\u2001\u2002' +
   '\u2003\u2004\u2005\u2006\u2007\u2008\u2009\u200A\u202F\u205F\u3000\u2028\u2029\uFEFF';
@@ -917,6 +917,7 @@ GLOBAL.tests = {
 
     return ''.replace(O) == 7
       && execCalled
+      // eslint-disable-next-line regexp/no-useless-dollar-replacements -- false positive
       && ''.replace(re2, '$<a>') === '7'
       // eslint-disable-next-line regexp/prefer-escape-replacement-dollar-char -- required for testing
       && 'a'.replace(/./, '$0') === '$0'

tests/tests/es.regexp.constructor.js

@@ -1,5 +1,5 @@
-/* eslint-disable regexp/order-in-character-class, regexp/no-dupe-characters-character-class -- required for testing */
-/* eslint-disable regexp/no-useless-character-class, regexp/no-useless-flag, regexp/sort-flags -- required for testing */
+/* eslint-disable regexp/no-invalid-regexp, regexp/sort-flags -- required for testing */
+/* eslint-disable regexp/no-useless-character-class, regexp/no-useless-flag -- required for testing */
 import { DESCRIPTORS, GLOBAL } from '../helpers/constants';
 import { nativeSubclass } from '../helpers/helpers';