Skip to content

Commit eac57e4

Browse files
Brian Vaughnzhengjitf
authored andcommitted
DevTools: Update named hooks match to use column number also (facebook#21833)
This prevents edge cases where AST nodes are incorrectly matched.
1 parent 0bf1e01 commit eac57e4

24 files changed

+324
-76
lines changed

.eslintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ packages/react-devtools-extensions/chrome/build
2121
packages/react-devtools-extensions/firefox/build
2222
packages/react-devtools-extensions/shared/build
2323
packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/
24+
packages/react-devtools-extensions/src/__tests__/__source__/__untransformed__/
2425
packages/react-devtools-extensions/src/ErrorTesterCompiled.js
2526
packages/react-devtools-inline/dist
2627
packages/react-devtools-shell/dist

.prettierignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ packages/react-devtools-extensions/chrome/build
33
packages/react-devtools-extensions/firefox/build
44
packages/react-devtools-extensions/shared/build
55
packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/
6+
packages/react-devtools-extensions/src/__tests__/__source__/__untransformed__/
67
packages/react-devtools-extensions/src/ErrorTesterCompiled.js
78
packages/react-devtools-inline/dist
89
packages/react-devtools-shell/dist
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
/**
2+
* Copyright (c) Facebook, Inc. and its affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
import {createContext, useContext} from 'react';
11+
12+
const A = createContext(1);
13+
const B = createContext(2);
14+
15+
export function Component() {
16+
const a = useContext(A);
17+
const b = useContext(B);
18+
19+
// prettier-ignore
20+
const c = useContext(A), d = useContext(B); // eslint-disable-line one-var
21+
22+
return a + b + c + d;
23+
}

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/bundle/index.js

Lines changed: 24 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/bundle/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/ComponentWithMultipleHooksPerLine.js

Lines changed: 30 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/ComponentWithMultipleHooksPerLine.js.map

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/index.js

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)