Skip to content

Commit 9631718

Browse files
jstejadazhengjitf
authored andcommitted
[DevTools] Emit new event when DevTools connects in standalone app (facebook#22848)
1 parent dd09fd4 commit 9631718

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

packages/react-devtools-core/src/standalone.js

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,17 @@ import type {InspectedElement} from 'react-devtools-shared/src/devtools/views/Co
4141

4242
installHook(window);
4343

44-
export type StatusListener = (message: string) => void;
44+
export type StatusTypes = 'server-connected' | 'devtools-connected' | 'error';
45+
export type StatusListener = (message: string, status: StatusTypes) => void;
4546
export type OnDisconnectedCallback = () => void;
4647

4748
let node: HTMLElement = ((null: any): HTMLElement);
4849
let nodeWaitingToConnectHTML: string = '';
4950
let projectRoots: Array<string> = [];
50-
let statusListener: StatusListener = (message: string) => {};
51+
let statusListener: StatusListener = (
52+
message: string,
53+
status?: StatusTypes,
54+
) => {};
5155
let disconnectedCallback: OnDisconnectedCallback = () => {};
5256

5357
// TODO (Webpack 5) Hopefully we can remove this prop after the Webpack 5 migration.
@@ -260,6 +264,7 @@ function initialize(socket: WebSocket) {
260264
});
261265

262266
log('Connected');
267+
statusListener('DevTools initialized.', 'devtools-connected');
263268
reload();
264269
}
265270

@@ -372,12 +377,15 @@ function startServer(
372377

373378
httpServer.on('error', event => {
374379
onError(event);
375-
statusListener('Failed to start the server.');
380+
statusListener('Failed to start the server.', 'error');
376381
startServerTimeoutID = setTimeout(() => startServer(port), 1000);
377382
});
378383

379384
httpServer.listen(port, () => {
380-
statusListener('The server is listening on the port ' + port + '.');
385+
statusListener(
386+
'The server is listening on the port ' + port + '.',
387+
'server-connected',
388+
);
381389
});
382390

383391
return {

0 commit comments

Comments
 (0)