Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Commit e0620b1

Browse files
committed
remove upper casing first character on headers in socker class
1 parent bdfe6ca commit e0620b1

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed

src/Client/Adapter/Socket.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ public function write($method, $uri, $httpVer = '1.1', $headers = [], $body = ''
381381
$request = $method . ' ' . $path . ' HTTP/' . $httpVer . "\r\n";
382382
foreach ($headers as $k => $v) {
383383
if (is_string($k)) {
384-
$v = ucfirst($k) . ': ' . $v;
384+
$v = $k . ': ' . $v;
385385
}
386386
$request .= $v . "\r\n";
387387
}

src/Client/Adapter/Test.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ public function write($method, $uri, $httpVer = '1.1', $headers = [], $body = ''
132132
$request = $method . ' ' . $path . ' HTTP/' . $httpVer . "\r\n";
133133
foreach ($headers as $k => $v) {
134134
if (is_string($k)) {
135-
$v = ucfirst($k) . ': ' . $v;
135+
$v = $k . ': ' . $v;
136136
}
137137
$request .= $v . "\r\n";
138138
}

test/Client/SocketTest.php

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,24 @@ public function testAllowsZeroWrittenBytes()
309309
$this->_adapter->write('GET', new Uri('tcp://localhost:80/'), '1.1', [], 'test body');
310310
}
311311

312+
/**
313+
* Verifies that the headers are being set as given without changing any
314+
* character case.
315+
*/
316+
public function testCaseInsensitiveHeaders()
317+
{
318+
$this->_adapter->connect('localhost');
319+
$requestString = $this->_adapter->write(
320+
'GET',
321+
new Uri('tcp://localhost:80/'),
322+
'1.1',
323+
['x-test-header' => 'someTestHeader'],
324+
'someTestBody'
325+
);
326+
327+
$this->assertContains('x-test-header', $requestString);
328+
}
329+
312330
/**
313331
* Data Providers
314332
*/

0 commit comments

Comments
 (0)