Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Commit 56a297f

Browse files
committed
Add new tests
Test correct handling of accept headers with trailing semicolon and with semicolon without equal sign
1 parent b3b51cb commit 56a297f

File tree

2 files changed

+24
-0
lines changed

2 files changed

+24
-0
lines changed

test/Header/AcceptEncodingTest.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,18 @@ public function testAcceptEncodingGetFieldValueReturnsProperValue()
3232
$this->assertEquals('xxx', $acceptEncodingHeader->getFieldValue());
3333
}
3434

35+
public function testAcceptEncodingGetFieldValueReturnsProperValueWithTrailingSemicolon()
36+
{
37+
$acceptEncodingHeader = AcceptEncoding::fromString('Accept-Encoding: xxx;');
38+
$this->assertEquals('xxx', $acceptEncodingHeader->getFieldValue());
39+
}
40+
41+
public function testAcceptEncodingGetFieldValueReturnsProperValueWithSemicolonWithoutEqualSign()
42+
{
43+
$acceptEncodingHeader = AcceptEncoding::fromString('Accept-Encoding: xxx;yyy');
44+
$this->assertEquals('xxx;yyy', $acceptEncodingHeader->getFieldValue());
45+
}
46+
3547
public function testAcceptEncodingToStringReturnsHeaderFormattedString()
3648
{
3749
$acceptEncodingHeader = new AcceptEncoding();

test/Header/AcceptLanguageTest.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,18 @@ public function testAcceptLanguageGetFieldValueReturnsProperValue()
3232
$this->assertEquals('xxx', $acceptLanguageHeader->getFieldValue());
3333
}
3434

35+
public function testAcceptLanguageGetFieldValueReturnsProperValueWithTrailingSemicolon()
36+
{
37+
$acceptLanguageHeader = AcceptLanguage::fromString('Accept-Language: xxx;');
38+
$this->assertEquals('xxx', $acceptLanguageHeader->getFieldValue());
39+
}
40+
41+
public function testAcceptLanguageGetFieldValueReturnsProperValueWithSemicolonWithoutEqualSign()
42+
{
43+
$acceptLanguageHeader = AcceptLanguage::fromString('Accept-Language: xxx;yyy');
44+
$this->assertEquals('xxx;yyy', $acceptLanguageHeader->getFieldValue());
45+
}
46+
3547
public function testAcceptLanguageToStringReturnsHeaderFormattedString()
3648
{
3749
$acceptLanguageHeader = new AcceptLanguage();

0 commit comments

Comments
 (0)