[VEG-662] Improve release and automate process #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarmadsangi
reviewed
Sep 8, 2021
Comment on lines
+25
to
+31
| git config user.name github-actions | ||
| git config user.email [email protected] | ||
| npm install | ||
| npm run build | ||
| npm version ${{ steps.tag.outputs.version }} --force -m "Upgrade to %s from github actions build_on_merge step [ci skip]" | ||
| npm publish | ||
| npm run release |
There was a problem hiding this comment.
these steps need to be tweaked, install, version, publish etc all happen in release.sh
sarmadsangi
reviewed
Sep 8, 2021
| "types": "lib/index.d.ts" | ||
| "types": "lib/index.d.ts", | ||
| "publishConfig": { | ||
| "registry": "https://zdrepo.jfrog.io/zdrepo/api/npm/npm" |
There was a problem hiding this comment.
i don't think we should hardcode this here, we publish for both public and internal, which means we should dynamically pass this value during the release https://github.com/lerna/lerna/tree/main/commands/publish#--registry-url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment ZCLI needs a manual release and will only publish to the NPM registry. This PR aims to include publish artifactory and automate the release on merge to master.
https://zendesk.atlassian.net/browse/VEG-662
Detail
Checklist