Skip to content

Commit 50d3850

Browse files
committed
Bump lerna from 5.1.8 to 8.1.5 (palindromic upgrade)
- Let's use the latest and greatest lerna - Note that `lerna bootstrap` is replaced with `yarn install` post lerna v7 [1], and since this was leveraged in a postinstall script we can (and should) just remove, as otherwise now `yarn install` will recursively install, forever. - Similarly, `lerna link` is no longer necessary post lerna v7, as package linking is done automagically as part of the `yarn install` process [2], so we should just delete any occurrences of this, such as in the link_dev script. [1] https://lerna.js.org/docs/legacy-package-management#:~:text=Replace%20lerna%20bootstrap%20with%20npm%20install%20(or%20yarn/pnpm).%20If%20you%20are%20already%20performing%20your%20package%20manager%27s%20install%20command%20somewhere%20in%20your%20workflow%20before%20where%20you%20had%20previously%20called%20lerna%20bootstrap%2C%20then%20you%20can%20just%20delete%20it%20instead [2] https://lerna.js.org/docs/legacy-package-management#:~:text=lerna%20link%20can%20just%20be%20removed%2C%20as%20the%20linking%20step%20is%20now%20handled%20by%20your%20package%20manager%20during%20npm%20install.
1 parent 3b164da commit 50d3850

File tree

5 files changed

+1584
-1753
lines changed

5 files changed

+1584
-1753
lines changed

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"eslint-plugin-node": "^11.1.0",
2525
"eslint-plugin-promise": "^6.0.0",
2626
"form-data": "^4.0.0",
27-
"lerna": "^5.1.8",
27+
"lerna": "^8.1.5",
2828
"lerna-changelog": "^2.2.0",
2929
"mocha": "^10.0.0",
3030
"nock": "^13.2.8",
@@ -46,7 +46,6 @@
4646
],
4747
"scripts": {
4848
"audit:fix": "yarn-audit-fix",
49-
"postinstall": "lerna bootstrap",
5049
"dev": "ts-node ./packages/zcli/bin/run",
5150
"git:check": "./scripts/git_check.sh",
5251
"link:bin": "bash ./scripts/link_dev.sh",

packages/zcli-apps/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
"eslint": "^8.18.0",
4646
"eslint-config-oclif": "^4.0.0",
4747
"eslint-config-oclif-typescript": "^1.0.2",
48-
"lerna": "^5.1.8",
48+
"lerna": "^8.1.5",
4949
"mocha": "^10.0.0",
5050
"sinon": "^14.0.0"
5151
},

packages/zcli-themes/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"eslint": "^8.18.0",
4040
"eslint-config-oclif": "^4.0.0",
4141
"eslint-config-oclif-typescript": "^1.0.2",
42-
"lerna": "^5.1.8",
42+
"lerna": "^8.1.5",
4343
"mocha": "^10.0.0",
4444
"nock": "^13.2.8",
4545
"sinon": "^14.0.0"

scripts/link_dev.sh

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ if [[ "$OSTYPE" == "cygwin" ]]; then
1010
JAVASCRIPT_ENTRYPOINT_PATH="$(cygpath -wa "$JAVASCRIPT_ENTRYPOINT_PATH" | tr '\\' '/')"
1111
fi
1212

13-
# link zcli-core & zcli-apps into ./packages/zcli/node_modules/@zendesk/
14-
npx lerna link
15-
1613
# determine where we should install the stub to
1714
YARN_GLOBAL_BIN_DIR="$(yarn global bin)"
1815
TYPESCRIPT_ENTRYPOINT_PATH="$YARN_GLOBAL_BIN_DIR/zcli"

0 commit comments

Comments
 (0)