Skip to content

Commit c91688e

Browse files
motiz88facebook-github-bot
authored andcommitted
Copy new Hermes CDP headers for iOS build (facebook#39365)
Summary: Pull Request resolved: facebook#39365 The new Hermes CDP introduces new directories & headers. These need to be copied just like the other headers that Hermes API provides. Changelog: [Internal] Reviewed By: dmytrorykun Differential Revision: D49067283 fbshipit-source-id: 0cf11470e123bf63c645466cb066f68b50bcac4a
1 parent 01d7ec1 commit c91688e

File tree

2 files changed

+35
-3
lines changed

2 files changed

+35
-3
lines changed

packages/react-native/sdks/hermes-engine/hermes-engine.podspec

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,18 @@ Pod::Spec.new do |spec|
7373
ss.header_dir = 'hermes'
7474
end
7575

76+
spec.subspec 'inspector' do |ss|
77+
ss.source_files = ''
78+
ss.public_header_files = 'API/hermes/inspector/*.h'
79+
ss.header_dir = 'hermes/inspector'
80+
end
81+
82+
spec.subspec 'inspector_chrome' do |ss|
83+
ss.source_files = ''
84+
ss.public_header_files = 'API/hermes/inspector/chrome/*.h'
85+
ss.header_dir = 'hermes/inspector/chrome'
86+
end
87+
7688
spec.subspec 'Public' do |ss|
7789
ss.source_files = ''
7890
ss.public_header_files = 'public/hermes/Public/*.h'

packages/react-native/sdks/hermes-engine/utils/build-apple-framework.sh

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,19 @@ function build_apple_framework {
121121
fi
122122

123123
# Copy over Hermes and JSI API headers.
124-
mkdir -p destroot/include/hermes/Public destroot/include/jsi
124+
mkdir -p destroot/include/hermes/Public
125125
cp public/hermes/Public/*.h destroot/include/hermes/Public
126+
127+
mkdir -p destroot/include/hermes
126128
cp API/hermes/*.h destroot/include/hermes
129+
130+
mkdir -p destroot/include/hermes/inspector
131+
cp API/hermes/inspector/*.h destroot/include/hermes/inspector
132+
133+
mkdir -p destroot/include/hermes/inspector/chrome
134+
cp API/hermes/inspector/chrome/*.h destroot/include/hermes/inspector/chrome
135+
136+
mkdir -p destroot/include/jsi
127137
cp "$JSI_PATH"/jsi/*.h destroot/include/jsi
128138
popd > /dev/null || exit 1
129139
}
@@ -137,10 +147,20 @@ function prepare_dest_root_for_ci {
137147
cp -R "./build_catalyst/API/hermes/hermes.framework"* "destroot/Library/Frameworks/catalyst"
138148
cp "./build_macosx/bin/"* "destroot/bin"
139149

140-
mkdir -p destroot/include/hermes/Public destroot/include/jsi
141-
150+
# Copy over Hermes and JSI API headers.
151+
mkdir -p destroot/include/hermes/Public
142152
cp public/hermes/Public/*.h destroot/include/hermes/Public
153+
154+
mkdir -p destroot/include/hermes
143155
cp API/hermes/*.h destroot/include/hermes
156+
157+
mkdir -p destroot/include/hermes/inspector
158+
cp API/hermes/inspector/*.h destroot/include/hermes/inspector
159+
160+
mkdir -p destroot/include/hermes/inspector/chrome
161+
cp API/hermes/inspector/chrome/*.h destroot/include/hermes/inspector/chrome
162+
163+
mkdir -p destroot/include/jsi
144164
cp "$JSI_PATH"/jsi/*.h destroot/include/jsi
145165
}
146166

0 commit comments

Comments
 (0)