[ie/soundcloud] Extract comments#16938
Merged
Merged
Conversation
…' of github.com:0xvd/yt-dlp-exp into add/soundcloud_comments
bashonly
requested changes
Jun 12, 2026
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
bashonly
requested changes
Jun 13, 2026
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
bashonly
requested changes
Jun 27, 2026
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
bashonly
reviewed
Jun 27, 2026
bashonly
reviewed
Jun 27, 2026
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
bashonly
reviewed
Jun 27, 2026
Comment on lines
+481
to
+482
| 'start_time': ('timestamp', {float_or_none(scale=1000)}), | ||
| 'end_time': ('timestamp', {float_or_none(scale=1000)}), |
Member
There was a problem hiding this comment.
Could you document these comment dict fields in the yt_dlp.extractor.common.InfoExtractor docstring, please?
Contributor
Author
There was a problem hiding this comment.
I added. Sorry If my English/Wording is not perfect.
bashonly
reviewed
Jun 27, 2026
bashonly
reviewed
Jun 27, 2026
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
bashonly
previously approved these changes
Jun 27, 2026
bashonly
left a comment
bashonly
left a comment
Member
There was a problem hiding this comment.
Thanks for enduring this review. Looks good now
Comment on lines
+464
to
+465
| yield traverse_obj(comment_dict, { | ||
| 'id': ('id', {int}, {str_or_none}), |
Member
There was a problem hiding this comment.
Good job refactoring this; I realized I should have suggested it this way after-the-fact
bashonly
approved these changes
Jun 27, 2026
bashonly
changed the title
bashonly
changed the title
Enucatl
pushed a commit
to Enucatl/yt-dlp
that referenced
this pull request
Jun 28, 2026
Closes yt-dlp#16717 Authored by: 0xvd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your pull request and other information
closes #16717
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check those that apply and remove the others:
What is the purpose of your pull request? Check those that apply and remove the others: