[utils] Deprecate make_dir in favor of make_parent_dirs#16931
Merged
Conversation
Member
|
I think we should actually raise and adjust the call sites accordingly: def make_dir(path, to_screen=None):
try:
makedirs(path)
return True
except OSError as err:
if to_screen is not None:
to_screen(f'unable to create directory {err}')
return False
def makedirs(path: str):
dn = os.path.dirname(path)
if dn:
os.makedirs(dn, exist_ok=True) |
Member
Author
|
makes sense, I'll replace |
make_dir: Fix callable() conditionmake_dir behavior to make_parent_dirs
bashonly
reviewed
Jun 11, 2026
bashonly
requested changes
Jun 12, 2026
bashonly
approved these changes
Jun 12, 2026
Grub4K
approved these changes
Jun 12, 2026
make_dir behavior to make_parent_dirsmake_dir in favor of make_parent_dirs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your pull request and other information
Fix directory creation error handling
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check those that apply and remove the others:
What is the purpose of your pull request? Check those that apply and remove the others: