vtctld: Remove experimental VSchema editor UI.#1839
Merged
Conversation
The experimental VSchema editor UI was originally intended as a learning tool to help explain VSchema concepts. We are removing it prior to the General Availability release because we don't want to encourage a workflow in which new VSchema is pushed instantly without review. Instead, VSchema configs should be under source control, and changes should be peer-reviewed before being pushed at an appropriate time by a DBA. This mirrors industry best practices for regular SQL schema changes. In a future release, we plan to incorporate an improved, holistic Schema+VSchema management system. For now, updates should be done through vtctlclient: http://vitess.io/reference/vtctl.html#applyvschema
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sougou
The experimental VSchema editor UI was originally intended as a learning
tool to help explain VSchema concepts. We are removing it prior to the
General Availability release because we don't want to encourage a workflow
in which new VSchema is pushed instantly without review.
Instead, VSchema configs should be under source control, and changes
should be peer-reviewed before being pushed at an appropriate time by a
DBA. This mirrors industry best practices for regular SQL schema changes.
In a future release, we plan to incorporate an improved, holistic
Schema+VSchema management system. For now, updates should be done through
vtctlclient:
http://vitess.io/reference/vtctl.html#applyvschema
This change is