Fix edge cases in MariaDB backup/restore + reparent scenarios.#1778
Merged
Conversation
added 2 commits
June 8, 2016 19:54
Although the demoted master case was working fine before, this is more correct.
This fixes an edge case where a gtid_strict_mode sanity check would fail when a slave tries to replicate starting at exactly the same GTID position at which the master's history began. For example, suppose the master was previously restored from a backup that had been taken at GTID position X, and then a slave connects and requests to replicate at exactly position X. The master would reject the attempt because it only has GTIDs AFTER X in its binlog - not X itself. Setting gtid_binlog_state upon restoring tells the master to assume that the given position existed in its binlogs prior to a purge. This allows the gtid_strict_mode sanity check to succeed.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@michael-berlin
This change is