Rowcache deprecation

[sougou]

@alainjobart @enisoc
Turning off the flags was trivial, which is the first change. But then, what's the long weekend for. I went ahead and deleted all the rowcache code also. Some areas needed refactoring.

---

This change is

[alainjobart]

good stuff :)

Previously, sougou wrote…

Rowcache deprecation

@alainjobart @enisoc

Turning off the flags was trivial, which is the first change. But then, what's the long weekend for. I went ahead and deleted all the rowcache code also. Some areas needed refactoring.

---

Reviewed 73 of 73 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[enisoc]

Reviewed 73 of 73 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

examples/kubernetes/vttablet-pod-benchmarking-template.yaml, line 77 [r1] (raw file):

          -enable_replication_reporter
          -rowcache-bin /usr/bin/memcached
          -rowcache-socket $VTDATAROOT/{{tablet_subdir}}/memcache.sock" vitess

This breaks the config because you removed the trailing " vitess. I'm going to remove memcached from the Docker images, so I'll fix this along with that.

---

Comments from Reviewable