Use native Go vendor mode for godeps.#1625
Merged
Merged
Conversation
Contributor
|
LGTM |
added 3 commits
April 6, 2016 14:43
This gets rid of the warning about disabling native vendor mode due to legacy Godeps/_workspace directory being present. It also means we require Go 1.5+ since that's when native vendor mode was first introduced.
Thanks to native vendoring support in Go 1.5+.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@alainjobart
This gets rid of the warning about disabling native vendor mode
due to legacy Godeps/_workspace directory being present.
It also means we require Go 1.5+ since that's when native vendor
mode was first introduced.
Later we can move more dependencies from
bootstrap.sh(go get) to vendoring. We'll need to decide if we want to use godeps to copy them into our repo, or use git submodules.This change is