Misc feature requests#1591
Merged
Merged
Conversation
This is only a partial support for allowing INTERVAL in the date & time functions. This precludes usage of INTERVAL as a function. We're deferring this grammar rework until a real need arises.
Unlike VALUE, it's not as offensive to require back-quoting of column names that are called 'next'. So, simplifying the code accordingly is worth it.
If we allowed '*' expressions in select, the postprocessing col refs can match them a-la-wildcard. There is no harm in this matching because no column numbers get used int the process, which is where things could break. However, we allow '*' expressions only if we know that we won't need column numbers. So, all is well.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@alainjobart
Some pending feature requests:
This change is