Sequence#1579
Merged
Merged
Conversation
The grammar change allows us to treat all FROM clauses uniformly. Additionally, we also address the awkard requirement of adding 'from dual' for sequence constructs.
In the case of sharded lookup tables, deleting a single keyspace id may result in a multi-shard delete for lookup vindexes. So, a signle delete that used an IN clause for unsharded tables won't work any ore. We have to instead issue each vindex row delete separately.
It turns out that NEXT and VALUE are not MySQL reserved words. So, this breaks certain constructs that use those ids as column names. This is a slight hack, but it should get us out of this issue for now.
The join tests have been rewritten to use different tables so they won't conflict with the other tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that suguwork is merged, I'm switching this pull request to target the master branch.
This is pre-approved. So, I'll be submitting this as soon as the tests pass.
This change is