Work branch to remove gorpc support.#1574
Merged
Merged
Conversation
Removing gorpc protocols flavor.
Switching default protocol to grpc.
It was only used to marshal / unmarshal GTIDs, but this was replaced already with the String version of these guys.
Go server cannot serve gorpc any more.
Using sleep for test synchronization is bad.
Contributor
Author
| wantFakeSleepCalled := (i <= *maxBufferSize) | ||
|
|
||
| wg.Add(1) | ||
| finished := make(chan struct{}) |
Contributor
There was a problem hiding this comment.
Cool, thanks for doing this!
LGTM
Contributor
|
Reviewed 3 of 5 files at r1, 12 of 12 files at r2, 10 of 10 files at r3, 10 of 11 files at r4, 4 of 4 files at r5, 15 of 15 files at r6, 7 of 7 files at r7, 3 of 3 files at r8, 28 of 28 files at r9, 37 of 37 files at r10, 1 of 1 files at r11. Comments from the review on Reviewable.io |
alainjobart
added a commit
that referenced
this pull request
Mar 16, 2016
Work branch to remove gorpc support.
Contributor
|
Pushed new bootstrap and lite images, tested k8s guide. |
Contributor
|
Published site. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will keep adding to it.
This change is