java: columnIndex starts at 1.

[enisoc]

@erzel The first commit is equivalent to the internal CL. The second needs to build on that.

---

This change is

[erzel]

Reviewed 8 of 8 files at r1.
Review status: 6 of 9 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

java/client/src/main/java/com/youtube/vitess/client/cursor/FieldMap.java, line 44 [r2] (raw file):
Check the upper-bound as well?

---

java/client/src/main/java/com/youtube/vitess/client/cursor/Row.java, line 35 [r2] (raw file):
Add a comment that column indices here are 1-based and perhaps also the motivation why.

---

Comments from the review on Reviewable.io

[erzel]

---

Review status: 6 of 9 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

Comments from the review on Reviewable.io

[enisoc]

Review status: 6 of 9 files reviewed at latest revision, 2 unresolved discussions.

---

java/client/src/main/java/com/youtube/vitess/client/cursor/FieldMap.java, line 44 [r2] (raw file):
In general this is just a wrapper around fields.get() which already checks bounds and will throw IndexOutOfBoundsException. The main reason for this checkArgument() is to assert that the index transformation done by this method (columnIndex - 1) is reasonable. In other words it asserts only the constraints being added by this method, not all the transitive constraints of methods it calls.

---

java/client/src/main/java/com/youtube/vitess/client/cursor/Row.java, line 35 [r2] (raw file):
Done.

---

Comments from the review on Reviewable.io