Full scan algorithm#1545
Merged
Merged
Conversation
Contributor
Author
|
@dumbuny can you take a look ? Thanks! Review status: 0 of 9 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from the review on Reviewable.io |
Contributor
Author
|
@dumbunny PTAL. Thanks! Review status: 0 of 9 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from the review on Reviewable.io |
Contributor
|
LGTM |
erzel
force-pushed
the
full_scan_algorithm
branch
2 times, most recently
from
548aa88 to
0bbdf76
Compare
…e command to generate mock_sql_executor
erzel
force-pushed
the
full_scan_algorithm
branch
from
0bbdf76 to
c92f950
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added implementation of FullScanAlgorithm and test.
Added tests for 3- and 1-tuple inequalities to splitter_test.go
@dumbunny note that I didn't bother optimizing the parenthesis-placement further. So for the scalar case (tuples with only one element), splitquery will return select * from t where (:start <= id) and (:end <= id).
I felt like it's not worth the extra complexity introduced into the code.
Let me know if you object.