Converting a few python clients to gRPC.#1484
Merged
Merged
Conversation
And a couple more details.
v3 demo can now use grpc, but it doesn't work as v3's keyrange construct produces invalid utf-8 strings. Will have to fix that.
Just use the v2 API, for debug purposes. Also now using grpc.
Contributor
Author
|
@dumbunny please look at vtgate_client.py changes. |
Contributor
|
LGTM for v3 changes. |
Contributor
|
Will the v3 demo change be visible in the demo UI? If not, I would prefer to have an indication of that. (Before this change, the queries matched very well with what was actually expected to happen.) |
Contributor
|
reviewed it, generally looks fine, but going to defer to others for their expertise. |
Contributor
Author
|
@michael-berlin there is no visible change to the v3 demo. Only the queries that were done internally to show the content of each shard were affected, as expected. So I don't think it's changing anything. |
Contributor
|
LGTM I'll update the guestbook app after you merge. |
alainjobart
added a commit
that referenced
this pull request
Feb 5, 2016
Converting a few python clients to gRPC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@enisoc @sougou @aaijazi
@enisoc Only one left is the guestbook app, as far as I can tell. It seems like an easy fix, but I don't have the test environment to make it. Do you mind looking at it? Thanks!