Skip to content

Refactor PHP client for better standards compliance#1457

Merged
enisoc merged 3 commits into
vitessio:masterfrom
enisoc:php
Jan 22, 2016
Merged

Refactor PHP client for better standards compliance#1457
enisoc merged 3 commits into
vitessio:masterfrom
enisoc:php

Conversation

@enisoc
Copy link
Copy Markdown
Contributor

@enisoc enisoc commented Jan 22, 2016

As suggested by @cyrrill in #1404.

  • Use namespaces.
  • Put each class in its own file.
  • Use class autoloading.
  • Switched my eclipse PDT formatter to PSR-2 mode.

@enisoc enisoc added the php label Jan 22, 2016
@alainjobart
Copy link
Copy Markdown
Contributor

alainjobart commented Jan 22, 2016

LGTM

enisoc pushed a commit that referenced this pull request Jan 22, 2016
Merge pull request #1457 from enisoc/php
c4ab3ea 
Refactor PHP client for better standards compliance
@enisoc enisoc merged commit c4ab3ea into vitessio:master Jan 22, 2016
@enisoc enisoc deleted the php branch January 22, 2016 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alainjobart alainjobart

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@enisoc @alainjobart