Compatibility with OSX. The commit also contains instructions for set…#1428
Conversation
…ting up Vitess on OSX.
There was a problem hiding this comment.
Could you mention the particular version of OS X that worked for you? Also include the space when referring to "OS X" in this doc.
There was a problem hiding this comment.
I would add:
... put the following line ... to [force the Go DNS resolver](https://golang.org/doc/go1.5#net):
to explain what this is for.
|
Thanks for the doc updates! This looks good to me. @alainjobart has volunteered to try it out on his Mac before we merge... |
There was a problem hiding this comment.
To get this step to work, I had to first run sudo chown -R $(whoami):admin /usr/local as recommended here:
I guess you had already done that since you've used Homebrew before?
There was a problem hiding this comment.
I also had to brew install pkg-config. Not sure if that's just because my first attempt at running this install line failed partway through due to the permission issues.
There was a problem hiding this comment.
Regarding the chown command - I was testing the whole process on a clean virtual machine, so the folder /usr/local didn't exist. Anyway, this is a Homebrew issue, it has nothing to do with Vitess, but I could mention it in the docs if you'd like.
Regarding pkg-config - I forgot to mention, that I had XCode installed, which probably already includes pkg-config (if not, I can check my command history, not sure now). I'll mention that in the docs.
|
Followed the instructions, everything worked great. Thank you for working on this! |
Compatibility with OSX. The commit also contains instructions for set…
There was a problem hiding this comment.
Did it not work on OS X with beta-1? Unfortunately, I'm going to have to change this back to beta-1, because grpc is not yet compatible with protobuf v3.0.0-beta-2 due to grpc/grpc#4505.
There was a problem hiding this comment.
not sure now, but probably not. I can test it tomorrow
There was a problem hiding this comment.
So I can confirm now that there is an error while building protobuf-beta-1 on OS X. I'm not really sure what to do now, do we have to wait for a grpc update?
Shouldn't this be mentioned in the docs to update the protobuf version on mac as a temporary workaround? Or maybe I could update the install_protobuf.sh script to build beta-2, if run on OS X? I suppose it shouldn't be a problem to have beta-2 on OS X, because vitess would be only used as a dev dependency there, not a real production instance.
There was a problem hiding this comment.
I like the idea of updating install_protobuf.sh to use beta-2 on OS X. Would you like to make a PR for that? If so, please include a comment that explains that OS X requires beta-2, but grpc doesn't build with beta-2 yet on Linux.
I'm guessing that the reason grpc builds with protobuf beta-2 on OS X is that the build skips the C# parts on that platform.
3 participants
…ting up Vitess on OSX.
I was able to get Vitess running on my Mac. Maybe it will be useful for some early adopters.