vtctl ApplySchema: Added flag -allow_long_unavailability.#1414
Merged
michael-berlin merged 7 commits intoJan 4, 2016
Merged
Conversation
There is currently no big schema change support in open source; therefore, it is better to allow schema manager to do big schema changes without enfocing 100,000 rows limit. Add flag "-force" for vtctl command "ApplySchema" so it accepts big schema changes.
schemamanager: Log warning that the flag is set only if it's actually a big schema. Added integration test using VtctlPipe. The test is based on copy_schema_shard_test.go.
…ed "null". Fixed this by removing the unused return value tmutils.SchemaChangeResult from the ApplySchema wrangler command.
Contributor
|
Great change, thanks for the associated clean-up. LGTM. |
michael-berlin
added a commit
that referenced
this pull request
Jan 4, 2016
…ply_schema vtctl ApplySchema: Added flag -allow_long_unavailability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, long running schema changes are rejected. With this new flag, this check can be bypassed and the changes applied anyway. As the name of the flag suggests, this can result in a longer period of unavailability.
The first commit is from Shengzhe from: #1241
@alainjobart