Skip to content

Commit 1bda4c2

Browse files
authored
starboard: Rename new NativeStability extension (#11537)
The struct and the identifier are both renamed to use "Starboard" instead of "Cobalt". This is our preference since b/150221489. This would normally be a breaking change but it's ok since this is a brand new extension that is not yet on any production devices. Issue: 528362453
1 parent 2c24ce4 commit 1bda4c2

8 files changed

Lines changed: 17 additions & 17 deletions

File tree

cobalt/browser/cobalt_browser_main_parts.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,8 +243,8 @@ int CobaltBrowserMainParts::PreMainMessageLoopRun() {
243243
// Remove this block once the NativeStabilityManager singleton is added to
244244
// the browser to query the extension to respond to web app requests.
245245
auto native_stability_extension =
246-
static_cast<const CobaltExtensionNativeStabilityApi*>(
247-
SbSystemGetExtension(kCobaltExtensionNativeStabilityName));
246+
static_cast<const StarboardExtensionNativeStabilityApi*>(
247+
SbSystemGetExtension(kStarboardExtensionNativeStabilityName));
248248
if (native_stability_extension && native_stability_extension->version >= 1 &&
249249
native_stability_extension->ReadReports) {
250250
constexpr int max_num_reports = 16; // A somewhat arbitrary, large number

starboard/contrib/rdk/src/third_party/starboard/rdk/shared/system/system_get_extensions.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ const void* SbSystemGetExtension(const char* name) {
7474
}
7575
#endif
7676
#if BUILDFLAG(USE_EVERGREEN)
77-
if (strcmp(name, kCobaltExtensionNativeStabilityName) == 0) {
77+
if (strcmp(name, kStarboardExtensionNativeStabilityName) == 0) {
7878
return starboard::GetNativeStabilityApi();
7979
}
8080
#endif

starboard/crashpad_wrapper/wrapper.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -365,8 +365,8 @@ void InstallCrashpadHandler(const std::string& ca_certificates_path) {
365365
}
366366

367367
auto native_stability_extension =
368-
static_cast<const CobaltExtensionNativeStabilityApi*>(
369-
SbSystemGetExtension(kCobaltExtensionNativeStabilityName));
368+
static_cast<const StarboardExtensionNativeStabilityApi*>(
369+
SbSystemGetExtension(kStarboardExtensionNativeStabilityName));
370370
if (native_stability_extension && native_stability_extension->version >= 1 &&
371371
native_stability_extension->RegisterReadReportsCallback) {
372372
native_stability_extension->RegisterReadReportsCallback(&ReadReports);

starboard/extension/extension_test.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -631,8 +631,8 @@ TEST(ExtensionTest, StarboardMediaBufferPoolExtension) {
631631
}
632632

633633
TEST(ExtensionTest, NativeStabilityExtension) {
634-
typedef CobaltExtensionNativeStabilityApi ExtensionApi;
635-
const char* kExtensionName = kCobaltExtensionNativeStabilityName;
634+
typedef StarboardExtensionNativeStabilityApi ExtensionApi;
635+
const char* kExtensionName = kStarboardExtensionNativeStabilityName;
636636

637637
const ExtensionApi* extension_api =
638638
static_cast<const ExtensionApi*>(SbSystemGetExtension(kExtensionName));

starboard/extension/native_stability.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
extern "C" {
2424
#endif
2525

26-
#define kCobaltExtensionNativeStabilityName \
27-
"dev.cobalt.extension.NativeStability"
26+
#define kStarboardExtensionNativeStabilityName \
27+
"dev.starboard.extension.NativeStability"
2828

2929
typedef enum SbNativeStabilityReportType {
3030
kSbNativeStabilityReportUnknown = 0,
@@ -44,8 +44,8 @@ typedef struct SbNativeStabilityReport {
4444
typedef int (*ReadReportsCallback)(SbNativeStabilityReport* reports,
4545
int max_num_reports);
4646

47-
typedef struct CobaltExtensionNativeStabilityApi {
48-
// Name should be the string |kCobaltExtensionNativeStabilityName|.
47+
typedef struct StarboardExtensionNativeStabilityApi {
48+
// Name should be the string |kStarboardExtensionNativeStabilityName|.
4949
// This helps to validate that the extension API is correct.
5050
const char* name;
5151

@@ -65,7 +65,7 @@ typedef struct CobaltExtensionNativeStabilityApi {
6565
// |ReadReports| implementation. This is used to delegate to an injected
6666
// dependency to avoid dependency cycles.
6767
void (*RegisterReadReportsCallback)(ReadReportsCallback callback);
68-
} CobaltExtensionNativeStabilityApi;
68+
} StarboardExtensionNativeStabilityApi;
6969

7070
#ifdef __cplusplus
7171
} // extern "C"

starboard/linux/shared/system_get_extensions.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ const void* SbSystemGetExtension(const char* name) {
6161
if (strcmp(name, kCobaltExtensionCrashHandlerName) == 0) {
6262
return starboard::GetCrashHandlerApi();
6363
}
64-
if (strcmp(name, kCobaltExtensionNativeStabilityName) == 0) {
64+
if (strcmp(name, kStarboardExtensionNativeStabilityName) == 0) {
6565
return starboard::GetNativeStabilityApi();
6666
}
6767

starboard/nplb/nplb_evergreen_compat_tests/native_stability_test.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ namespace nplb {
2727
namespace {
2828

2929
TEST(NativeStabilityTest, VerifyNativeStabilityExtension) {
30-
auto extension = static_cast<const CobaltExtensionNativeStabilityApi*>(
31-
SbSystemGetExtension(kCobaltExtensionNativeStabilityName));
30+
auto extension = static_cast<const StarboardExtensionNativeStabilityApi*>(
31+
SbSystemGetExtension(kStarboardExtensionNativeStabilityName));
3232

3333
ASSERT_NE(extension, nullptr)
3434
<< "Please update your platform's SbSystemGetExtension() implementation "

starboard/shared/starboard/native_stability.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ void RegisterReadReportsCallback(ReadReportsCallback callback) {
4343
SB_CHECK_EQ(pthread_mutex_unlock(&g_read_reports_callback_mutex), 0);
4444
}
4545

46-
const CobaltExtensionNativeStabilityApi kNativeStabilityApi = {
47-
kCobaltExtensionNativeStabilityName,
46+
const StarboardExtensionNativeStabilityApi kNativeStabilityApi = {
47+
kStarboardExtensionNativeStabilityName,
4848
1,
4949
&ReadReports,
5050
&RegisterReadReportsCallback,

0 commit comments

Comments
 (0)