Skip to content

Commit 48aced6

Browse files
authored
Test on latest stable PHP 8.4 + Symfony 7.3 (#40)
* Fixed deprecated notation for PHPCS * Test on latest stable PHP 8.4 + Symfony 7.3 * Fixed deprecation for PHP 8.4, Drop PHP <8.0 support, Drop Symfony <6.0 support
1 parent 800c0b3 commit 48aced6

File tree

4 files changed

+15
-17
lines changed

4 files changed

+15
-17
lines changed

.github/workflows/tests.yml

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,11 @@ jobs:
1515
strategy:
1616
matrix:
1717
include:
18-
- php-version: 7.4
19-
symfony-version: 4.4.*
20-
sonata-version: ^4.0
21-
- php-version: 8.0
22-
symfony-version: 5.4.*
23-
sonata-version: ^4.0
2418
- php-version: 8.1
25-
symfony-version: 6.1.*
19+
symfony-version: 6.4.*
2620
sonata-version: ^4.0
27-
- php-version: 8.3
28-
symfony-version: 7.2.*
21+
- php-version: 8.4
22+
symfony-version: 7.3.*
2923
sonata-version: ^4.0
3024

3125
steps:
@@ -54,8 +48,8 @@ jobs:
5448
strategy:
5549
matrix:
5650
include:
57-
- php-version: 8.1
58-
symfony-version: 6.1.*
51+
- php-version: 8.4
52+
symfony-version: 7.3.*
5953

6054
steps:
6155
- name: "Checkout"
@@ -81,8 +75,8 @@ jobs:
8175
strategy:
8276
matrix:
8377
include:
84-
- php-version: 8.1
85-
symfony-version: 6.1.*
78+
- php-version: 8.4
79+
symfony-version: 7.3.*
8680

8781
steps:
8882
- name: "Checkout"

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@
2525
}
2626
},
2727
"require": {
28-
"php": "^7.4|^8.0",
28+
"php": "^8.0",
2929
"sonata-project/admin-bundle": "^4.0",
30-
"symfony/workflow": "^4.4|^5.0|^6.0|^7.0"
30+
"symfony/workflow": "^6.0|^7.0"
3131
},
3232
"require-dev": {
3333
"phpunit/phpunit": "^9.5",

phpcs.xml.dist

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,11 @@
1515

1616
<rule ref="Generic.PHP.ForbiddenFunctions">
1717
<properties>
18-
<property name="forbiddenFunctions" type="array" value="dump=>null,var_dump=>null,die=>null"/>
18+
<property name="forbiddenFunctions" type="array">
19+
<element key="dump" value="null"/>
20+
<element key="var_dump" value="null"/>
21+
<element key="die" value="null"/>
22+
</property>
1923
</properties>
2024
</rule>
2125

src/Admin/Extension/WorkflowExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public function getAccessMapping(AdminInterface $admin): array
107107
/**
108108
* @throws InvalidArgumentException
109109
*/
110-
protected function getWorkflow(object $subject, string $workflowName = null): WorkflowInterface
110+
protected function getWorkflow(object $subject, string|null $workflowName = null): WorkflowInterface
111111
{
112112
return $this->registry->get($subject, $workflowName);
113113
}

0 commit comments

Comments
 (0)