Upgrade to prometheus/common 0.62.0 with breaking change (prometheus#1712)

common 0.62.0 switches NameValidationScheme global variable to UTF8Validation.
While relaxing validation this will likely yield test failures downstream.

It's unfortunate, but the alternatives were worse: prometheus/common#724

Good news is that client_golang should work with older common deps and callers can
easily change model.NameValidationScheme value to old value to solve any compatibility issues.

Signed-off-by: bwplotka <[email protected]>

Author: bwplotka

prometheus/counter_test.go

@@ -291,7 +291,7 @@ func TestCounterExemplar(t *testing.T) {
 			}
 		}()
 		// Should panic because of invalid label name.
-		counter.AddWithExemplar(42, Labels{":o)": "smile"})
+		counter.AddWithExemplar(42, Labels{"in\x80valid": "smile"})
 		return nil
 	}
 	if addExemplarWithInvalidLabel() == nil {

prometheus/internal/go_runtime_metrics.go

@@ -66,7 +66,8 @@ func RuntimeMetricsToProm(d *metrics.Description) (string, string, string, bool)
 		name += "_total"
 	}
 
-	valid := model.IsValidMetricName(model.LabelValue(namespace + "_" + subsystem + "_" + name))
+	// Our current conversion moves to legacy naming, so use legacy validation.
+	valid := model.IsValidLegacyMetricName(namespace + "_" + subsystem + "_" + name)
 	switch d.Kind {
 	case metrics.KindUint64:
 	case metrics.KindFloat64:

prometheus/promhttp/instrument_server_test.go

@@ -66,7 +66,7 @@ func TestLabelCheck(t *testing.T) {
 		},
 		"all labels used with an invalid const label name": {
 			varLabels:     []string{"code", "method"},
-			constLabels:   []string{"in-valid", "bar"},
+			constLabels:   []string{"in\x80valid", "bar"},
 			curriedLabels: []string{"dings", "bums"},
 			dynamicLabels: []string{"dyn", "amics"},
 			ok:            false,
@@ -120,14 +120,14 @@ func TestLabelCheck(t *testing.T) {
 			ok:            false,
 		},
 		"invalid name and otherwise empty": {
-			metricName:    "in-valid",
+			metricName:    "in\x80valid",
 			varLabels:     []string{},
 			constLabels:   []string{},
 			curriedLabels: []string{},
 			ok:            false,
 		},
 		"invalid name with all the otherwise valid labels": {
-			metricName:    "in-valid",
+			metricName:    "in\x80valid",
 			varLabels:     []string{"code", "method"},
 			constLabels:   []string{"foo", "bar"},
 			curriedLabels: []string{"dings", "bums"},

prometheus/push/push_test.go

@@ -229,7 +229,7 @@ func TestPush(t *testing.T) {
 		t.Error("push with grouping contained in metrics succeeded")
 	}
 	if err := New(pgwOK.URL, "testjob").
-		Grouping("foo-bar", "bums").
+		Grouping("foo\x80bar", "bums").
 		Collector(metric1).
 		Collector(metric2).
 		Push(); err == nil {

prometheus/wrap_test.go

@@ -153,7 +153,7 @@ func TestWrap(t *testing.T) {
 			output: []Collector{simpleGge, labeledPreCnt},
 		},
 		"wrap counter with invalid prefix": {
-			prefix:      "1+1",
+			prefix:      "1\x801",
 			preRegister: []Collector{simpleGge},
 			toRegister: []struct {
 				collector         Collector
@@ -163,7 +163,7 @@ func TestWrap(t *testing.T) {
 		},
 		"wrap counter with invalid label": {
 			preRegister: []Collector{simpleGge},
-			labels:      Labels{"42": "bar"},
+			labels:      Labels{"\x80": "bar"},
 			toRegister: []struct {
 				collector         Collector
 				registrationFails bool