Skip to content

Implement Deref<Target=str> for Key #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jstarry merged 1 commit into from
Jul 4, 2020
Merged

Implement Deref<Target=str> for Key #1370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions yew/src/virtual_dom/key.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
//! This module contains the implementation yew's virtual nodes' keys.

use std::ops::Deref;
use std::rc::Rc;

/// Represents the (optional) key of Yew's virtual nodes.
Expand Down Expand Up @@ -29,6 +30,15 @@ impl From<Rc<String>> for Key {
}
}

impl Deref for Key {
type Target = str;

#[inline]
Copy link
Contributor

@teymour-aldridge teymour-aldridge Jul 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the advantage of inlining this?

Copy link
Contributor Author

@faulesocke faulesocke Jul 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know what I was thinking, but at least it's also in std::Strings impl marked as inline. Should I remove it?

Copy link
Contributor

@teymour-aldridge teymour-aldridge Jul 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess explicitly inlining this might make LLVM do some more optimization work, but I don't think it really matters.

fn deref(&self) -> &str {
self.key.as_ref()
}
}

macro_rules! key_impl_from_to_string {
($type:ty) => {
impl From<$type> for Key {
Expand Down