Fix fetch test for same-origin referrer URL#1788
Merged
siku2 merged 1 commit intoyewstack:masterfrom Mar 13, 2021
Merged
Conversation
The `yew_services::fetch::tests::fetch_referrer_same_origin_url` test broke for Chrome after Chrome changed the default `Referrer-Policy` from `no-referrer-when-downgrade` to `strict-origin-when-cross-origin` (See: https://developers.google.com/web/updates/2020/07/referrer-policy-new-chrome-default) The test makes a cross-site fetch (from the headless test origin to the httpbin server) and the new default policy causes the path to be stripped from the `Referer` header, whereas the old policy didn't. Fix this problem by explicitly setting the referrer policy to the previous default `no-referrer-when-downgrade` when making the test fetch. This makes the test pass with Chrome and should have no effect for other browsers which are still using a default of `no-referrer-when-downgrade` (i.e. Firefox). Tested with both Chrome and Firefox: * wasm-pack test --chrome --headless -- --features "wasm_test httpbin_test" * wasm-pack test --firefox --headless -- --features "wasm_test httpbin_test"
Member
|
Thanks so much for tracking this down ❤️ |
cecton
pushed a commit
to siku2/yew
that referenced
this pull request
Mar 13, 2021
The `yew_services::fetch::tests::fetch_referrer_same_origin_url` test broke for Chrome after Chrome changed the default `Referrer-Policy` from `no-referrer-when-downgrade` to `strict-origin-when-cross-origin` (See: https://developers.google.com/web/updates/2020/07/referrer-policy-new-chrome-default) The test makes a cross-site fetch (from the headless test origin to the httpbin server) and the new default policy causes the path to be stripped from the `Referer` header, whereas the old policy didn't. Fix this problem by explicitly setting the referrer policy to the previous default `no-referrer-when-downgrade` when making the test fetch. This makes the test pass with Chrome and should have no effect for other browsers which are still using a default of `no-referrer-when-downgrade` (i.e. Firefox). Tested with both Chrome and Firefox: * wasm-pack test --chrome --headless -- --features "wasm_test httpbin_test" * wasm-pack test --firefox --headless -- --features "wasm_test httpbin_test"
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
yew_services::fetch::tests::fetch_referrer_same_origin_urltest broke for Chrome after Chrome changed the default
Referrer-Policyfromno-referrer-when-downgradetostrict-origin-when-cross-origin(See: https://developers.google.com/web/updates/2020/07/referrer-policy-new-chrome-default)
The test makes a cross-site fetch (from the headless test
origin to the
httpbinserver) and the new default policycauses the path to be stripped from the
Refererheader,whereas the old policy didn't.
Fix this problem by explicitly setting the referrer policy
to the previous default
no-referrer-when-downgradewhenmaking the test fetch. This makes the test pass with Chrome
and should have no effect for other browsers which are
still using a default of
no-referrer-when-downgrade(i.e. Firefox).
Tested with both Chrome and Firefox:
wasm-pack test --chrome --headless -- --features "wasm_test httpbin_test"wasm-pack test --firefox --headless -- --features "wasm_test httpbin_test"Fixes #1787
Checklist
cargo make pr-flow