remove wrongly placed diagnostic attribute

Madoshakalaka · Madoshakalaka · commit f5f68d30b312 · 2025-07-08T19:14:32.000+09:00
diff --git a/packages/yew-macro/src/derive_props/builder.rs b/packages/yew-macro/src/derive_props/builder.rs
@@ -127,7 +127,6 @@ impl PropsBuilder<'_> {
         quote! {
             #[automatically_derived]
             #( #extra_attrs )*
-            #[diagnostic::do_not_recommend]
             impl #builder_impl_generics #builder_name<#generic_args> #builder_where_clause {
                 #( #prop_fns )*
             }
diff --git a/packages/yew-macro/tests/derive_props/fail.stderr b/packages/yew-macro/tests/derive_props/fail.stderr
@@ -68,7 +68,6 @@ error[E0277]: not all required properties have been provided
    |                        ^^^^^ missing required properties for this component
    |
    = help: the trait `HasProp<t3::_Props::value, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<t3::PropsBuilder, _>`
-   = note: make sure all required properties are set before building the component
 note: required for `t3::CheckPropsAll<AssertAllProps>` to implement `HasAllProps<t3::Props, (_,)>`
   --> tests/derive_props/fail.rs:29:21
    |
@@ -92,7 +91,6 @@ error[E0277]: not all required properties have been provided
    |                        ^^^^^ missing required properties for this component
    |
    = help: the trait `HasProp<t4::_Props::value, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<t4::PropsBuilder, _>`
-   = note: make sure all required properties are set before building the component
 note: required for `t4::CheckPropsAll<AssertAllProps>` to implement `HasAllProps<t4::Props, (_,)>`
   --> tests/derive_props/fail.rs:41:21
    |
diff --git a/packages/yew-macro/tests/function_component_attr/generic-props-fail.stderr b/packages/yew-macro/tests/function_component_attr/generic-props-fail.stderr
@@ -16,7 +16,6 @@ error[E0277]: not all required properties have been provided
    |              ^^^^ missing required properties for this component
    |
    = help: the trait `HasProp<a, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<PropsBuilder, _>`
-   = note: make sure all required properties are set before building the component
 note: required for `CheckPropsAll<AssertAllProps>` to implement `HasAllProps<Props, (_,)>`
   --> tests/function_component_attr/generic-props-fail.rs:3:17
    |
diff --git a/packages/yew-macro/tests/html_macro/component-fail.stderr b/packages/yew-macro/tests/html_macro/component-fail.stderr
@@ -578,7 +578,6 @@ error[E0277]: not all required properties have been provided
    |              ^^^^^ missing required properties for this component
    |
    = help: the trait `HasProp<int, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<ChildPropertiesBuilder, _>`
-   = note: make sure all required properties are set before building the component
 note: required for `CheckChildPropertiesAll<AssertAllProps>` to implement `HasAllProps<ChildProperties, (_,)>`
   --> tests/html_macro/component-fail.rs:4:17
    |
@@ -629,7 +628,6 @@ error[E0277]: not all required properties have been provided
     |              ^^^^^^^^^^^^^^ missing required properties for this component
     |
     = help: the trait `HasProp<_ChildContainerProperties::children, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<ChildContainerPropertiesBuilder, _>`
-    = note: make sure all required properties are set before building the component
 note: required for `CheckChildContainerPropertiesAll<AssertAllProps>` to implement `HasAllProps<ChildContainerProperties, (_,)>`
    --> tests/html_macro/component-fail.rs:24:17
     |
@@ -653,7 +651,6 @@ error[E0277]: not all required properties have been provided
     |              ^^^^^^^^^^^^^^ missing required properties for this component
     |
     = help: the trait `HasProp<_ChildContainerProperties::children, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<ChildContainerPropertiesBuilder, _>`
-    = note: make sure all required properties are set before building the component
 note: required for `CheckChildContainerPropertiesAll<AssertAllProps>` to implement `HasAllProps<ChildContainerProperties, (_,)>`
    --> tests/html_macro/component-fail.rs:24:17
     |
diff --git a/packages/yew-macro/tests/html_macro/missing-props-diagnostics-fail.stderr b/packages/yew-macro/tests/html_macro/missing-props-diagnostics-fail.stderr
@@ -5,7 +5,6 @@ error[E0277]: not all required properties have been provided
    |          ^^^ missing required properties for this component
    |
    = help: the trait `HasProp<bar, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<FooPropsBuilder, _>`
-   = note: make sure all required properties are set before building the component
 note: required for `CheckFooPropsAll<AssertAllProps>` to implement `HasAllProps<FooProps, (_, _)>`
   --> tests/html_macro/missing-props-diagnostics-fail.rs:24:10
    |
@@ -29,7 +28,6 @@ error[E0277]: not all required properties have been provided
    |          ^^^ missing required properties for this component
    |
    = help: the trait `HasProp<baz, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<FooPropsBuilder, _>`
-   = note: make sure all required properties are set before building the component
 note: required for `CheckFooPropsAll<AssertAllProps>` to implement `HasAllProps<FooProps, (_, _)>`
   --> tests/html_macro/missing-props-diagnostics-fail.rs:24:10
    |
@@ -53,7 +51,6 @@ error[E0277]: property `baz` is required but not provided
    |          ^^^ missing required property `baz`
    |
    = help: the trait `HasProp<baz, _>` is not implemented for `AssertAllProps`, which is required by `HasFooPropsbar<AssertAllProps>: AllPropsFor<FooPropsBuilder, _>`
-   = note: the component requires the property `baz` to be set
    = help: the following other types implement trait `HasProp<P, How>`:
              <HasFooPropsbar<B> as HasProp<bar, HasFooPropsbar<B>>>
              <HasFooPropsbar<B> as HasProp<P, &dyn HasProp<P, How>>>
diff --git a/packages/yew/src/html/component/properties.rs b/packages/yew/src/html/component/properties.rs
@@ -27,8 +27,7 @@ mod __macro {
     ///   the conflict.
     #[diagnostic::on_unimplemented(
         message = "property `{P}` is required but not provided",
-        label = "missing required property `{P}`",
-        note = "the component requires the property `{P}` to be set"
+        label = "missing required property `{P}`"
     )]
     pub trait HasProp<P, How> {}
 
@@ -39,8 +38,7 @@ mod __macro {
     /// [`Properties`]: super::Properties
     #[diagnostic::on_unimplemented(
         message = "not all required properties have been provided for `{P}`",
-        label = "missing required properties",
-        note = "ensure all required properties are set for the component"
+        label = "missing required properties"
     )]
     pub trait HasAllProps<P, How> {}
 
@@ -93,8 +91,7 @@ mod __macro {
     /// provided to the builder.
     #[diagnostic::on_unimplemented(
         message = "not all required properties have been provided",
-        label = "missing required properties for this component",
-        note = "make sure all required properties are set before building the component"
+        label = "missing required properties for this component"
     )]
     pub trait AllPropsFor<Builder, How> {}
 

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,6 @@ impl PropsBuilder<'_> {`
`127`	`127`	`quote! {`
`128`	`128`	`#[automatically_derived]`
`129`	`129`	`#( #extra_attrs )*`
`130`		`- #[diagnostic::do_not_recommend]`
`131`	`130`	`impl #builder_impl_generics #builder_name<#generic_args> #builder_where_clause {`
`132`	`131`	`#( #prop_fns )*`
`133`	`132`	`}`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,6 @@ error[E0277]: not all required properties have been provided`
`68`	`68`	`\| ^^^^^ missing required properties for this component`
`69`	`69`	`\|`
`70`	`70`	= help: the trait `HasProp<t3::_Props::value, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<t3::PropsBuilder, _>`
`71`		`- = note: make sure all required properties are set before building the component`
`72`	`71`	note: required for `t3::CheckPropsAll<AssertAllProps>` to implement `HasAllProps<t3::Props, (_,)>`
`73`	`72`	`--> tests/derive_props/fail.rs:29:21`
`74`	`73`	`\|`
`@@ -92,7 +91,6 @@ error[E0277]: not all required properties have been provided`
`92`	`91`	`\| ^^^^^ missing required properties for this component`
`93`	`92`	`\|`
`94`	`93`	= help: the trait `HasProp<t4::_Props::value, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<t4::PropsBuilder, _>`
`95`		`- = note: make sure all required properties are set before building the component`
`96`	`94`	note: required for `t4::CheckPropsAll<AssertAllProps>` to implement `HasAllProps<t4::Props, (_,)>`
`97`	`95`	`--> tests/derive_props/fail.rs:41:21`
`98`	`96`	`\|`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,6 @@ error[E0277]: not all required properties have been provided`
`16`	`16`	`\| ^^^^ missing required properties for this component`
`17`	`17`	`\|`
`18`	`18`	= help: the trait `HasProp<a, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<PropsBuilder, _>`
`19`		`- = note: make sure all required properties are set before building the component`
`20`	`19`	note: required for `CheckPropsAll<AssertAllProps>` to implement `HasAllProps<Props, (_,)>`
`21`	`20`	`--> tests/function_component_attr/generic-props-fail.rs:3:17`
`22`	`21`	`\|`
Original file line number	Diff line number	Diff line change
`@@ -578,7 +578,6 @@ error[E0277]: not all required properties have been provided`
`578`	`578`	`\| ^^^^^ missing required properties for this component`
`579`	`579`	`\|`
`580`	`580`	= help: the trait `HasProp<int, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<ChildPropertiesBuilder, _>`
`581`		`- = note: make sure all required properties are set before building the component`
`582`	`581`	note: required for `CheckChildPropertiesAll<AssertAllProps>` to implement `HasAllProps<ChildProperties, (_,)>`
`583`	`582`	`--> tests/html_macro/component-fail.rs:4:17`
`584`	`583`	`\|`
`@@ -629,7 +628,6 @@ error[E0277]: not all required properties have been provided`
`629`	`628`	`\| ^^^^^^^^^^^^^^ missing required properties for this component`
`630`	`629`	`\|`
`631`	`630`	= help: the trait `HasProp<_ChildContainerProperties::children, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<ChildContainerPropertiesBuilder, _>`
`632`		`- = note: make sure all required properties are set before building the component`
`633`	`631`	note: required for `CheckChildContainerPropertiesAll<AssertAllProps>` to implement `HasAllProps<ChildContainerProperties, (_,)>`
`634`	`632`	`--> tests/html_macro/component-fail.rs:24:17`
`635`	`633`	`\|`
`@@ -653,7 +651,6 @@ error[E0277]: not all required properties have been provided`
`653`	`651`	`\| ^^^^^^^^^^^^^^ missing required properties for this component`
`654`	`652`	`\|`
`655`	`653`	= help: the trait `HasProp<_ChildContainerProperties::children, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<ChildContainerPropertiesBuilder, _>`
`656`		`- = note: make sure all required properties are set before building the component`
`657`	`654`	note: required for `CheckChildContainerPropertiesAll<AssertAllProps>` to implement `HasAllProps<ChildContainerProperties, (_,)>`
`658`	`655`	`--> tests/html_macro/component-fail.rs:24:17`
`659`	`656`	`\|`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,6 @@ error[E0277]: not all required properties have been provided`
`5`	`5`	`\| ^^^ missing required properties for this component`
`6`	`6`	`\|`
`7`	`7`	= help: the trait `HasProp<bar, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<FooPropsBuilder, _>`
`8`		`- = note: make sure all required properties are set before building the component`
`9`	`8`	note: required for `CheckFooPropsAll<AssertAllProps>` to implement `HasAllProps<FooProps, (_, _)>`
`10`	`9`	`--> tests/html_macro/missing-props-diagnostics-fail.rs:24:10`
`11`	`10`	`\|`
`@@ -29,7 +28,6 @@ error[E0277]: not all required properties have been provided`
`29`	`28`	`\| ^^^ missing required properties for this component`
`30`	`29`	`\|`
`31`	`30`	= help: the trait `HasProp<baz, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<FooPropsBuilder, _>`
`32`		`- = note: make sure all required properties are set before building the component`
`33`	`31`	note: required for `CheckFooPropsAll<AssertAllProps>` to implement `HasAllProps<FooProps, (_, _)>`
`34`	`32`	`--> tests/html_macro/missing-props-diagnostics-fail.rs:24:10`
`35`	`33`	`\|`
@@ -53,7 +51,6 @@ error[E0277]: property `baz` is required but not provided
`53`	`51`	\| ^^^ missing required property `baz`
`54`	`52`	`\|`
`55`	`53`	= help: the trait `HasProp<baz, _>` is not implemented for `AssertAllProps`, which is required by `HasFooPropsbar<AssertAllProps>: AllPropsFor<FooPropsBuilder, _>`
`56`		- = note: the component requires the property `baz` to be set
`57`	`54`	= help: the following other types implement trait `HasProp<P, How>`:
`58`	`55`	`<HasFooPropsbar<B> as HasProp<bar, HasFooPropsbar<B>>>`
`59`	`56`	`<HasFooPropsbar<B> as HasProp<P, &dyn HasProp<P, How>>>`