Skip to content

Added support sysview pathtype to cli and sdk #20095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Added support sysview pathtype to cli and sdk #20095

merged 1 commit into from
Jun 24, 2025

Conversation

n00bcracker
Copy link
Collaborator

This is a part of the PR series aimed to support a new pathtype SystemView. Previously system views were treated like ordinal tables so for now we want to remain this behavior.

@github-actions GitHub Actions
Copy link

🟢 2025-06-24 10:48:29 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@n00bcracker n00bcracker linked an issue Jun 24, 2025 that may be closed by this pull request
Support a new SysView pathtype in cpp SDK and cli #20096
Open
@n00bcracker n00bcracker mentioned this pull request Jun 20, 2025
Open
23 tasks
@n00bcracker n00bcracker marked this pull request as ready for review June 24, 2025 13:08
@n00bcracker n00bcracker requested review from a team as code owners June 24, 2025 13:08
@n00bcracker n00bcracker enabled auto-merge (squash) June 24, 2025 13:15
Gazizonoki
Gazizonoki requested changes Jun 24, 2025
View reviewed changes
@n00bcracker n00bcracker force-pushed the sdk_support_sysview_pathtype branch from ad4ea86 to 620d980 Compare June 24, 2025 13:59
Gazizonoki
Gazizonoki approved these changes Jun 24, 2025
View reviewed changes
Copy link
Collaborator

@Gazizonoki Gazizonoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK - ok

pnv1
pnv1 approved these changes Jun 24, 2025
View reviewed changes
Copy link
Collaborator

@pnv1 pnv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI part LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2025 •
edited
Loading

⚪ 2025-06-24 14:06:49 UTC Pre-commit check linux-x86_64-release-asan for 1c22ae2 has started.
⚪ 2025-06-24 14:06:58 UTC Artifacts will be uploaded here
⚪ 2025-06-24 14:10:25 UTC ya make is running...
🟡 2025-06-24 16:36:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16123 15716 0 122 256 29

🟢 2025-06-24 16:38:15 UTC Build successful.
🔴 2025-06-24 16:38:42 UTC ydbd size 3.9 GiB changed* by +3.8 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 29f8f7b merge: 1c22ae2 diff diff %
ydbd size 4 187 914 984 Bytes 4 191 870 104 Bytes +3.8 MiB +0.094%
ydbd stripped size 1 451 761 528 Bytes 1 453 113 048 Bytes +1.3 MiB +0.093%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2025 •
edited
Loading

⚪ 2025-06-24 14:14:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1c22ae2 has started.
⚪ 2025-06-24 14:14:33 UTC Artifacts will be uploaded here
⚪ 2025-06-24 14:18:09 UTC ya make is running...
🟡 2025-06-24 16:10:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38406 35670 0 4 2690 42

⚪ 2025-06-24 16:14:41 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-24 16:28:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
821 (only retried tests) 729 0 14 48 30

⚪ 2025-06-24 16:29:13 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-06-24 16:40:16 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
704 (only retried tests) 637 0 1 37 29

🟢 2025-06-24 16:40:26 UTC Build successful.
🟢 2025-06-24 16:40:47 UTC ydbd size 2.2 GiB changed* by -64 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: d6db40f merge: 1c22ae2 diff diff %
ydbd size 2 382 766 808 Bytes 2 382 766 744 Bytes -64 Bytes -0.000%
ydbd stripped size 498 847 464 Bytes 498 847 400 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@n00bcracker n00bcracker added the rebase-and-check Rebase PR with the current base branch and check label Jun 24, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jun 24, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2025 •
edited
Loading

⚪ 2025-06-24 18:33:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for fd0f80e has started.
⚪ 2025-06-24 18:33:21 UTC Artifacts will be uploaded here
⚫ 2025-06-24 18:33:43 UTC Check cancelled

@n00bcracker n00bcracker added the rebase-and-check Rebase PR with the current base branch and check label Jun 24, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jun 24, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2025 •
edited
Loading

⚪ 2025-06-24 18:35:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for fd0f80e has started.
⚪ 2025-06-24 18:36:07 UTC Artifacts will be uploaded here
⚪ 2025-06-24 18:39:29 UTC ya make is running...
🟡 2025-06-24 20:01:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38407 35684 0 2 2671 50

⚪ 2025-06-24 20:05:17 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-24 20:15:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
527 (only retried tests) 455 0 1 43 28

⚪ 2025-06-24 20:15:25 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-06-24 20:23:44 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
341 (only retried tests) 298 0 0 2 41

🟢 2025-06-24 20:23:52 UTC Build successful.
🟢 2025-06-24 20:24:15 UTC ydbd size 2.2 GiB changed* by +2.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 04c388e merge: fd0f80e diff diff %
ydbd size 2 382 766 744 Bytes 2 382 768 816 Bytes +2.0 KiB +0.000%
ydbd stripped size 498 847 400 Bytes 498 847 784 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2025 •
edited
Loading

⚪ 2025-06-24 18:36:59 UTC Pre-commit check linux-x86_64-release-asan for fd0f80e has started.
⚪ 2025-06-24 18:37:11 UTC Artifacts will be uploaded here
⚪ 2025-06-24 18:40:41 UTC ya make is running...
🟡 2025-06-24 20:46:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16124 15679 0 138 280 27

🟢 2025-06-24 20:47:56 UTC Build successful.
🟢 2025-06-24 20:48:25 UTC ydbd size 3.9 GiB changed* by +4.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a6a72eb merge: fd0f80e diff diff %
ydbd size 4 191 872 696 Bytes 4 191 877 616 Bytes +4.8 KiB +0.000%
ydbd stripped size 1 453 114 104 Bytes 1 453 118 552 Bytes +4.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@n00bcracker n00bcracker merged commit 08a60a9 into ydb-platform:main Jun 24, 2025
23 of 27 checks passed
@n00bcracker n00bcracker deleted the sdk_support_sysview_pathtype branch June 24, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnv1 pnv1 pnv1 approved these changes

@Gazizonoki Gazizonoki Gazizonoki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support a new SysView pathtype in cpp SDK and cli
3 participants
@n00bcracker @pnv1 @Gazizonoki