Skip to content

added a new path type for system views #18038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

added a new path type for system views #18038

merged 1 commit into from
May 6, 2025

Conversation

n00bcracker
Copy link
Collaborator

Changelog entry

Added new enum values for system view paths in SchemeShard, SchemeCache, Viewer, KiCli.

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

New enum values for system views. First part of changes for support materialized sys view paths.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2025 •
edited
Loading

⚪ 2025-05-05 16:24:11 UTC Pre-commit check linux-x86_64-release-asan for 00cdda7 has started.
⚪ 2025-05-05 16:24:22 UTC Artifacts will be uploaded here
⚪ 2025-05-05 16:27:47 UTC ya make is running...
🟡 2025-05-05 18:34:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14889 14711 0 90 63 25

⚪ 2025-05-05 18:36:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-05 19:06:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
938 (only retried tests) 844 0 46 22 26

⚪ 2025-05-05 19:06:29 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-05 19:32:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
776 (only retried tests) 682 0 44 25 25

🟢 2025-05-05 19:32:27 UTC Build successful.
🟢 2025-05-05 19:33:03 UTC ydbd size 3.8 GiB changed* by +120 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: bb3efc3 merge: 00cdda7 diff diff %
ydbd size 4 126 695 752 Bytes 4 126 695 872 Bytes +120 Bytes +0.000%
ydbd stripped size 1 433 278 200 Bytes 1 433 278 296 Bytes +96 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2025 •
edited
Loading

⚪ 2025-05-05 16:26:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 00cdda7 has started.
⚪ 2025-05-05 16:26:58 UTC Artifacts will be uploaded here
⚪ 2025-05-05 16:30:06 UTC ya make is running...
🟡 2025-05-05 18:26:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29713 27033 0 7 2633 40

⚪ 2025-05-05 18:28:34 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-05 18:42:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
139 (only retried tests) 102 0 2 0 35

⚪ 2025-05-05 18:42:27 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-05-05 19:20:35 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
135 (only retried tests) 101 0 2 0 32

🟢 2025-05-05 19:20:41 UTC Build successful.
🟢 2025-05-05 19:21:05 UTC ydbd size 2.2 GiB changed* by +96 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: bb3efc3 merge: 00cdda7 diff diff %
ydbd size 2 343 493 376 Bytes 2 343 493 472 Bytes +96 Bytes +0.000%
ydbd stripped size 493 068 608 Bytes 493 068 672 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2025

🟢 2025-05-05 16:29:06 UTC The validation of the Pull Request description is successful.

@n00bcracker n00bcracker force-pushed the add_sysview_pathtype branch from 31e1026 to f62cd2f Compare May 6, 2025 09:24
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025 •
edited
Loading

⚪ 2025-05-06 14:08:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 391982a has started.
⚪ 2025-05-06 14:09:25 UTC Artifacts will be uploaded here
⚪ 2025-05-06 14:13:20 UTC ya make is running...
🟡 2025-05-06 15:23:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29718 27044 0 1 2633 40

⚪ 2025-05-06 15:26:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-06 15:51:55 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
568 (only retried tests) 533 0 0 0 35

🟢 2025-05-06 15:52:04 UTC Build successful.
🟢 2025-05-06 15:52:18 UTC ydbd size 2.2 GiB changed* by +176 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0f55ef2 merge: 391982a diff diff %
ydbd size 2 343 599 608 Bytes 2 343 599 784 Bytes +176 Bytes +0.000%
ydbd stripped size 493 088 992 Bytes 493 089 120 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@n00bcracker n00bcracker marked this pull request as ready for review May 6, 2025 09:27
@n00bcracker n00bcracker requested review from a team as code owners May 6, 2025 09:27
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025 •
edited
Loading

⚪ 2025-05-06 09:27:21 UTC Pre-commit check linux-x86_64-release-asan for 391982a has started.
⚪ 2025-05-06 09:27:32 UTC Artifacts will be uploaded here
⚪ 2025-05-06 09:30:39 UTC ya make is running...
🟡 2025-05-06 11:38:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14893 14745 0 76 46 26

⚪ 2025-05-06 11:40:07 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-06 12:08:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
914 (only retried tests) 815 0 45 29 25

⚪ 2025-05-06 12:09:08 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-06 12:35:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
772 (only retried tests) 680 0 42 24 26

🟢 2025-05-06 12:35:49 UTC Build successful.
🟢 2025-05-06 12:36:21 UTC ydbd size 3.8 GiB changed* by +656 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0f55ef2 merge: 391982a diff diff %
ydbd size 4 126 869 592 Bytes 4 126 870 248 Bytes +656 Bytes +0.000%
ydbd stripped size 1 433 326 552 Bytes 1 433 326 840 Bytes +288 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@n00bcracker n00bcracker linked an issue May 6, 2025 that may be closed by this pull request
Add enum values for system views to proto and .h files #18058
Closed
CyberROFL
CyberROFL reviewed May 6, 2025
View reviewed changes
snaury
snaury approved these changes May 6, 2025
View reviewed changes
ydb/core/tx/schemeshard/schemeshard_impl.cpp
@@ -4469,6 +4472,7 @@ NKikimrSchemeOp::TPathVersion TSchemeShard::GetPathVersion(const TPath& path) co
break;
}

case NKikimrSchemeOp::EPathType::EPathTypeSysView:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Придираться пока не буду (т.к. это всё временно), но вообще лучше никогда не добавлять то, что когда-либо может (в будущем) встретиться под Y_UNREACHABLE, потому что Y_UNREACHABLE - это гарантированное UB с непредсказуемым результатом.

@n00bcracker n00bcracker enabled auto-merge (squash) May 6, 2025 13:56
@n00bcracker n00bcracker merged commit 0dafe76 into ydb-platform:main May 6, 2025
18 of 19 checks passed
@n00bcracker n00bcracker deleted the add_sysview_pathtype branch May 7, 2025 15:52
@n00bcracker n00bcracker mentioned this pull request May 13, 2025
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijon ijon ijon approved these changes

@snaury snaury snaury approved these changes

@CyberROFL CyberROFL CyberROFL approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add enum values for system views to proto and .h files
4 participants
@n00bcracker @ijon @snaury @CyberROFL