Added create and drop scheme ops for sysview path type (#18089)

Author: n00bcracker

ydb/core/protos/counters_schemeshard.proto

@@ -247,6 +247,10 @@ enum ESimpleCounters {
 
     COUNTER_TENANT_DATA_ERASURE_QUEUE_SIZE = 194          [(CounterOpts) = {Name: "TenantDataErasureQueueSize"}];
     COUNTER_TENANT_DATA_ERASURE_QUEUE_RUNNING = 195       [(CounterOpts) = {Name: "TenantDataErasureQueueRunning"}];
+
+    COUNTER_SYS_VIEW_COUNT = 196                    [(CounterOpts) = {Name: "SysViewCount"}];
+    COUNTER_IN_FLIGHT_OPS_TxCreateSysView = 197     [(CounterOpts) = {Name: "InFlightOps/CreateSysView"}];
+    COUNTER_IN_FLIGHT_OPS_TxDropSysView = 198       [(CounterOpts) = {Name: "InFlightOps/DropSysView"}];
 }
 
 enum ECumulativeCounters {
@@ -397,6 +401,9 @@ enum ECumulativeCounters {
 
     COUNTER_TENANT_DATA_ERASURE_OK = 117                   [(CounterOpts) = {Name: "TenantDataErasureOK"}];
     COUNTER_TENANT_DATA_ERASURE_TIMEOUT = 118              [(CounterOpts) = {Name: "TenantDataErasureTimeout"}];
+
+    COUNTER_FINISHED_OPS_TxCreateSysView = 119              [(CounterOpts) = {Name: "FinishedOps/CreateSysView"}];
+    COUNTER_FINISHED_OPS_TxDropSysView = 120                [(CounterOpts) = {Name: "FinishedOps/DropSysView"}];
 }
 
 enum EPercentileCounters {

ydb/core/protos/flat_scheme_op.proto

@@ -11,6 +11,7 @@ import "ydb/core/protos/replication.proto";
 import "ydb/core/protos/s3_settings.proto";
 import "ydb/core/protos/schemeshard/operations.proto";
 import "ydb/core/protos/subdomains.proto";
+import "ydb/core/protos/sys_view_types.proto";
 import "ydb/core/protos/table_stats.proto";
 import "ydb/core/protos/tablet.proto";
 import "ydb/core/protos/yql_translation_settings.proto";
@@ -1754,6 +1755,8 @@ message TModifyScheme {
 
     optional TMove MoveSequence = 77;
 
+    optional TSysViewDescription CreateSysView = 81;
+
     // Some entries are grouped by semantics, so are out of order
 }
 
@@ -1880,6 +1883,7 @@ message TPathVersion {
     optional uint64 ViewVersion = 29;
     optional uint64 ResourcePoolVersion = 30;
     optional uint64 BackupCollectionVersion = 31;
+    optional uint64 SysViewVersion = 32;
 }
 
 // Describes single path
@@ -1971,6 +1975,7 @@ message TPathDescription {
     optional TViewDescription ViewDescription = 29;
     optional TResourcePoolDescription ResourcePoolDescription = 30;
     optional TBackupCollectionDescription BackupCollectionDescription = 31;
+    optional TSysViewDescription SysViewDescription = 32;
 }
 
 // For persisting AlterTable Tx description in Schemeshard internal DB
@@ -2183,3 +2188,8 @@ message TExportMetadata {
     optional string EncryptionAlgorithm = 3;
     optional bytes IV = 4;
 }
+
+message TSysViewDescription {
+    optional string Name = 1;
+    optional NKikimrSysView.ESysViewType Type = 2;
+}

ydb/core/protos/schemeshard/operations.proto

@@ -173,7 +173,10 @@ enum EOperationType {
     ESchemeOpAlterTransfer = 113;
     ESchemeOpDropTransfer = 114;
     ESchemeOpDropTransferCascade = 115;
-    
-    
+
+    // SysView
+    ESchemeOpCreateSysView = 116;
+    ESchemeOpDropSysView = 117;
+
     // Some entries are grouped by semantics, so are out of order
 }

ydb/core/protos/sys_view_types.proto

@@ -0,0 +1,7 @@
+package NKikimrSysView;
+
+option java_package = "ru.yandex.kikimr.proto";
+
+enum ESysViewType {
+    EPartitionStats = 1;
+}

ydb/core/protos/ya.make

@@ -129,6 +129,7 @@ SRCS(
     stream.proto
     subdomains.proto
     sys_view.proto
+    sys_view_types.proto
     table_service_config.proto
     table_stats.proto
     tablet.proto

ydb/core/tx/schemeshard/schemeshard__init.cpp

@@ -1952,6 +1952,28 @@ struct TSchemeShard::TTxInit : public TTransactionBase<TSchemeShard> {
             }
         }
 
+        // Read SysViews
+        {
+            auto rowset = db.Table<Schema::SysView>().Range().Select();
+            if (!rowset.IsReady()) {
+                return false;
+            }
+
+            while (!rowset.EndOfSet()) {
+                TLocalPathId localPathId = rowset.GetValue<Schema::SysView::PathId>();
+                TPathId pathId(selfId, localPathId);
+
+                auto& sysView = Self->SysViews[pathId] = new TSysViewInfo();
+                sysView->AlterVersion = rowset.GetValue<Schema::SysView::AlterVersion>();
+                sysView->Type = rowset.GetValue<Schema::SysView::SysViewType>();
+                Self->IncrementPathDbRefCount(pathId);
+
+                if (!rowset.Next()) {
+                    return false;
+                }
+            }
+        }
+
         // Resorce Pool
         {
             auto rowset = db.Table<Schema::ResourcePool>().Range().Select();

ydb/core/tx/schemeshard/schemeshard__operation.cpp

@@ -1262,6 +1262,12 @@ ISubOperation::TPtr TOperation::RestorePart(TTxState::ETxType txType, TTxState::
     case TTxState::ETxType::TxDropBackupCollection:
         return CreateDropBackupCollection(NextPartId(), txState);
 
+    // SysView
+    case TTxState::ETxType::TxCreateSysView:
+        return CreateNewSysView(NextPartId(), txState);
+    case TTxState::ETxType::TxDropSysView:
+        return CreateDropSysView(NextPartId(), txState);
+
     case TTxState::ETxType::TxInvalid:
         Y_UNREACHABLE();
     }
@@ -1560,6 +1566,12 @@ TVector<ISubOperation::TPtr> TDefaultOperationFactory::MakeOperationParts(
         return CreateBackupIncrementalBackupCollection(op.NextPartId(), tx, context);
     case NKikimrSchemeOp::EOperationType::ESchemeOpRestoreBackupCollection:
         return CreateRestoreBackupCollection(op.NextPartId(), tx, context);
+
+    // SysView
+    case NKikimrSchemeOp::EOperationType::ESchemeOpCreateSysView:
+        return {CreateNewSysView(op.NextPartId(), tx)};
+    case NKikimrSchemeOp::EOperationType::ESchemeOpDropSysView:
+        return {CreateDropSysView(op.NextPartId(), tx)};
     }
 
     Y_UNREACHABLE();