fix(display): Update display import (#1709)

* fix: improve type checking logic in _is_cast_type_defined function

* fix: update IPython import paths to use the correct module

* Revert "fix: improve type checking logic in _is_cast_type_defined function"

This reverts commit 65e424c.

---------

Co-authored-by: Fabiana <[email protected]>

Author: walterdiaza

src/ydata_profiling/profile_report.py

@@ -509,7 +509,7 @@ def to_notebook_iframe(self) -> None:
         Notes:
             This constructions solves problems with conflicting stylesheets and navigation links.
         """
-        from IPython.core.display import display
+        from IPython.display import display
 
         from ydata_profiling.report.presentation.flavours.widget.notebook import (
             get_notebook_iframe,
@@ -532,7 +532,7 @@ def to_widgets(self) -> None:
         except ModuleNotFoundError:
             pass
 
-        from IPython.core.display import display
+        from IPython.display import display
 
         display(self.widgets)
 

src/ydata_profiling/report/presentation/flavours/widget/correlation_table.py

@@ -1,4 +1,4 @@
-from IPython.core.display import display
+from IPython.display import display
 from ipywidgets import Output, widgets
 
 from ydata_profiling.report.presentation.core.correlation_table import CorrelationTable

src/ydata_profiling/report/presentation/flavours/widget/duplicate.py

@@ -1,4 +1,4 @@
-from IPython.core.display import display
+from IPython.display import display
 from ipywidgets import Output, widgets
 
 from ydata_profiling.report.presentation.core.duplicate import Duplicate

src/ydata_profiling/report/presentation/flavours/widget/notebook.py

@@ -5,7 +5,7 @@
 from typing import TYPE_CHECKING, Union
 
 if TYPE_CHECKING:
-    from IPython.core.display import HTML
+    from IPython.display import HTML
     from IPython.lib.display import IFrame
 
 from ydata_profiling import ProfileReport
@@ -22,7 +22,7 @@ def get_notebook_iframe_srcdoc(config: Settings, profile: ProfileReport) -> "HTM
     Returns:
         IPython HTML object.
     """
-    from IPython.core.display import HTML
+    from IPython.display import HTML
 
     width = config.notebook.iframe.width
     height = config.notebook.iframe.height

src/ydata_profiling/report/presentation/flavours/widget/sample.py

@@ -1,4 +1,4 @@
-from IPython.core.display import display
+from IPython.display import display
 from ipywidgets import Output, widgets
 
 from ydata_profiling.report.presentation.core.sample import Sample

src/ydata_profiling/utils/notebook.py

@@ -3,6 +3,6 @@
 
 def full_width() -> None:
     """Resize the notebook to use it's full width"""
-    from IPython.core.display import HTML, display
+    from IPython.display import HTML, display
 
     display(HTML("<style>.container { width:100% !important; }</style>"))

tests/notebooks/meteorites.ipynb

@@ -60,6 +60,13 @@
     "df = pd.concat([df, duplicates_to_add], ignore_index=True)"
    ]
   },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": []
+  },
   {
    "cell_type": "code",
    "execution_count": null,
@@ -77,7 +84,7 @@
     "    display(pr)\n",
     "\n",
     "assert len(out.outputs) == 2\n",
-    "assert out.outputs[0].data[\"text/plain\"] == \"<IPython.core.display.HTML object>\"\n",
+    "assert out.outputs[0].data[\"text/plain\"] == \"<IPython.display.HTML object>\"\n",
     "assert out.outputs[1].data[\"text/plain\"] == \"\""
    ]
   },
@@ -129,7 +136,7 @@
     "    display(pfr)\n",
     "\n",
     "assert len(out.outputs) == 2\n",
-    "assert out.outputs[0].data[\"text/plain\"] == \"<IPython.core.display.HTML object>\"\n",
+    "assert out.outputs[0].data[\"text/plain\"] == \"<IPython.display.HTML object>\"\n",
     "assert out.outputs[1].data[\"text/plain\"] == \"\""
    ]
   }

tests/notebooks/titanic.ipynb

@@ -93,7 +93,7 @@
     "\n",
     "# assert len(out.outputs) == 2\n",
     "# assert out.outputs[0].data['text/plain'].startswith('Tab(children=(HTML(value=')\n",
-    "# assert out.outputs[1].data['text/plain'] == '<IPython.core.display.HTML object>'\n",
+    "# assert out.outputs[1].data['text/plain'] == '<IPython.display.HTML object>'\n",
     "# assert 'ydata-profiling' in out.outputs[1].data['text/html']"
    ]
   },
@@ -108,7 +108,7 @@
     "    profile.to_notebook_iframe()\n",
     "\n",
     "assert len(out.outputs) == 1\n",
-    "assert out.outputs[0].data[\"text/plain\"] == \"<IPython.core.display.HTML object>\""
+    "assert out.outputs[0].data[\"text/plain\"] == \"<IPython.display.HTML object>\""
    ]
   }
  ],