Skip to content

Commit d8ff0c6

Browse files
Karl BeldanJyri Sarha
authored andcommitted
drm/tilcdc: Adjust the FB_CEILING address
commit ee8c42b upstream. The LCDC seems to expect its framebuffer ceiling address pointer to be an inclusive bound. The IP rev2 seems to cope with that but rev1 (as found on the LCDK) don't. Also note that this is what the framebuffer code does in da8xx-fb.c. Since, as the TRM puts it, "The 2 LSBs are hardwired to 00b", the dma_addr_t can be decremented without cast. I tested it with a v2 (AM335x, rev 0x4F201000) and an LCDK (v1). Signed-off-by: Karl Beldan <[email protected]> Signed-off-by: Jyri Sarha <[email protected]>
1 parent e462acc commit d8ff0c6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/tilcdc/tilcdc_crtc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ static void set_scanout(struct drm_crtc *crtc, struct drm_framebuffer *fb)
8080
end = start + (crtc->mode.vdisplay * fb->pitches[0]);
8181

8282
tilcdc_write(dev, LCDC_DMA_FB_BASE_ADDR_0_REG, start);
83-
tilcdc_write(dev, LCDC_DMA_FB_CEILING_ADDR_0_REG, end);
83+
tilcdc_write(dev, LCDC_DMA_FB_CEILING_ADDR_0_REG, end - 1);
8484

8585
if (tilcdc_crtc->curr_fb)
8686
drm_flip_work_queue(&tilcdc_crtc->unref_work,

0 commit comments

Comments
 (0)