Upgrade gulp v4 #6143
Upgrade gulp v4 #6143
Conversation
|
| gulp.task('build', () => | ||
| build('lib', babelRc.env[majorVer >= 5 ? 'node5' : 'pre-node5']) | ||
| ); | ||
|
|
||
| gulp.task('watch', ['build'], () => { | ||
| watch('src/**/*', () => { | ||
| gulp.start('build'); |
There was a problem hiding this comment.
I'm not a gulp expert by any means, but it seems like we're doing gulp.task('build') a lot in here. Is there a good way to clean that up a bit so it's more terse? (e.g. const buildTask = gulp.task('build')) Or is this just the standard/canonical/usual/conventional way to do it?
There was a problem hiding this comment.
Looking at a sample in their README, it says, "You can still use gulp.task to expose tasks", but I'm not sure if they're implying that one should or shouldn't.
gulp.task('build', build);
There was a problem hiding this comment.
I don't think it matters whether tasks are exported using gulp.task or by exporting them from the module, it's just a matter of style.
As for the repeated use of gulp.task('build'), it looks like the best way to avoid that is to just use the function reference instead. i.e. gulp.task('default', build)
That can't be done as things are currently, because build is a helper function. The actual build task is an anonymous function that calls the build function. I see no reason not to merge those two functions into one. After that, instances of gulp.task('build') could be replaced with build.
Gulp v4 integrates a watch mecanism, there is no need for gulp-watch anymore.
aduh95
force-pushed
the
upgrade-gulp-v4
branch
from
34aa031 to
f84824f
Compare
|
Thanks! 👍 |
Summary
Update to Gulp v4 and drop deprecated
gulp-utildependency.Also, it drops
gulp-watchas it is now integrated within the gulp API.Motivation
This PR is motivated by the warnings showing up when performing
yarn installon this repo. Also, it removeslodash v1.0.2dependency which is using the deprecatedBufferconstructor.