Skip to content

Commit 327b021

Browse files
committed
fix maybeCoerceNumber()
1 parent 61faf08 commit 327b021

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -497,13 +497,13 @@ function parse (args, opts) {
497497
}
498498

499499
function maybeCoerceNumber (key, value) {
500+
if (Array.isArray(value)) return value
501+
500502
if (!checkAllAliases(key, flags.strings) && !checkAllAliases(key, flags.coercions)) {
501503
const shouldCoerceNumber = isNumber(value) && configuration['parse-numbers'] && (
502504
Number.isSafeInteger(Math.floor(value))
503505
)
504-
if (shouldCoerceNumber || (!isUndefined(value) && checkAllAliases(key, flags.numbers))) {
505-
value = Array.isArray(value) ? [Number(value)] : Number(value)
506-
}
506+
if (shouldCoerceNumber || (!isUndefined(value) && checkAllAliases(key, flags.numbers))) value = Number(value)
507507
}
508508
return value
509509
}

test/yargs-parser.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2201,10 +2201,11 @@ describe('yargs-parser', function () {
22012201
parsed['x'].should.equal('b')
22022202
})
22032203
it('array[string]: keeps all arguments - ignores configuration', function () {
2204-
var parsed = parser('-x a -x b -y c', {
2204+
var parsed = parser('-x a -x b -y c -z d e', {
22052205
array: [
22062206
{ key: 'x', string: true },
2207-
{ key: 'y', string: true }
2207+
{ key: 'y', string: true },
2208+
{ key: 'z', string: true }
22082209
],
22092210
configuration: {
22102211
'duplicate-arguments-array': false
@@ -2213,12 +2214,14 @@ describe('yargs-parser', function () {
22132214

22142215
parsed['x'].should.deep.equal(['a', 'b'])
22152216
parsed['y'].should.deep.equal(['c'])
2217+
parsed['z'].should.deep.equal(['d', 'e'])
22162218
})
22172219
it('array[number]: keeps all arguments - ignores configuration', function () {
2218-
var parsed = parser('-x 1 -x 2 -y 3', {
2220+
var parsed = parser('-x 1 -x 2 -y 3 -z 4 5', {
22192221
array: [
22202222
{ key: 'x', number: true },
2221-
{ key: 'y', number: true }
2223+
{ key: 'y', number: true },
2224+
{ key: 'z', number: true }
22222225
],
22232226
configuration: {
22242227
'duplicate-arguments-array': false
@@ -2227,6 +2230,7 @@ describe('yargs-parser', function () {
22272230

22282231
parsed['x'].should.deep.equal([1, 2])
22292232
parsed['y'].should.deep.equal([3])
2233+
parsed['z'].should.deep.equal([4, 5])
22302234
})
22312235
it('does not interfere with nargs', function () {
22322236
var parsed = parser('-x a b c -x o p q', {

0 commit comments

Comments
 (0)