Merge pull request #131 from kevinmatthe/bugfix/fix_double_free

🐛 fix(jieba): 修复内存释放问题

Author: yanyiwu

jieba.go

@@ -7,10 +7,11 @@ package gojieba
 */
 import "C"
 import (
+	"fmt"
+	"os"
 	"runtime"
+	"sync/atomic"
 	"unsafe"
-	"os"
-	"fmt"
 )
 
 type TokenizeMode int
@@ -28,11 +29,12 @@ type Word struct {
 
 type Jieba struct {
 	jieba C.Jieba
+	freed int32
 }
 
 func NewJieba(paths ...string) *Jieba {
 	dictpaths := getDictPaths(paths...)
-	
+
 	// check if the dictionary files exist
 	for _, path := range dictpaths {
 		if _, err := os.Stat(path); os.IsNotExist(err) {
@@ -54,14 +56,17 @@ func NewJieba(paths ...string) *Jieba {
 			ipath,
 			spath,
 		),
+		0,
 	}
 	// set finalizer to free the memory when the object is garbage collected
 	runtime.SetFinalizer(jieba, (*Jieba).Free)
 	return jieba
 }
 
 func (x *Jieba) Free() {
-	C.FreeJieba(x.jieba)
+	if atomic.CompareAndSwapInt32(&x.freed, 0, 1) { // only free once
+		C.FreeJieba(x.jieba)
+	}
 }
 
 func (x *Jieba) Cut(s string, hmm bool) []string {

jieba_test.go

@@ -3,6 +3,7 @@ package gojieba
 import (
 	"fmt"
 	"reflect"
+	"runtime"
 	"strings"
 	"testing"
 )
@@ -267,3 +268,10 @@ func BenchmarkExtractor(b *testing.B) {
 		x.ExtractWithWeight(s, 10)
 	}
 }
+
+func TestTypicalDoubleFree(t *testing.T) {
+	x := NewJieba()
+	defer x.Free()
+
+	runtime.GC() // call GC to run finalizers
+}