Respect .eslintignore (#377)

Author: kevinastone

index.js

@@ -34,7 +34,10 @@ const processReport = (report, options) => {
 const runEslint = (paths, options) => {
 	const config = optionsManager.buildConfig(options);
 	const engine = new eslint.CLIEngine(config);
-	const report = engine.executeOnFiles(paths, config);
+	const report = engine.executeOnFiles(
+		paths.filter(path => !engine.isPathIgnored(path)),
+		config,
+	);
 	return processReport(report, options);
 };
 
@@ -58,12 +61,15 @@ module.exports.lintText = (string, options) => {
 		throw new Error('The `ignores` option requires the `filename` option to be defined.');
 	}
 
+	const engine = new eslint.CLIEngine(options);
+
 	if (options.filename) {
 		const filename = path.relative(options.cwd, options.filename);
 
 		if (
 			multimatch(filename, options.ignores).length > 0 ||
-			globby.gitignore.sync({cwd: options.cwd, ignore: options.ignores})(options.filename)
+			globby.gitignore.sync({cwd: options.cwd, ignore: options.ignores})(options.filename) ||
+			engine.isPathIgnored(options.filename)
 		) {
 			return {
 				errorCount: 0,
@@ -78,7 +84,6 @@ module.exports.lintText = (string, options) => {
 		}
 	}
 
-	const engine = new eslint.CLIEngine(options);
 	const report = engine.executeOnText(string, options.filename);
 
 	return processReport(report, options);

readme.md

@@ -177,7 +177,7 @@ Additional global variables your code accesses during execution.
 
 Type: `string[]`
 
-Some [paths](lib/options-manager.js) are ignored by default, including paths in `.gitignore`. Additional ignores can be added here.
+Some [paths](lib/options-manager.js) are ignored by default, including paths in `.gitignore` and [.eslintignore](https://eslint.org/docs/user-guide/configuring#eslintignore). Additional ignores can be added here.
 
 ### space
 

test/fixtures/eslintignore/.eslintignore

@@ -0,0 +1 @@
+bar.js

test/fixtures/eslintignore/bar.js

@@ -0,0 +1 @@
+console.log('no semicolon')

test/fixtures/eslintignore/foo.js

@@ -0,0 +1 @@
+console.log('no semicolon')

test/lint-files.js

@@ -120,3 +120,14 @@ test('enable rules based on nodeVersion', async t => {
 		)
 	);
 });
+
+test('do not lint eslintignored files', async t => {
+	const cwd = path.join(__dirname, 'fixtures/eslintignore/');
+	const glob = path.posix.join(cwd, '*');
+	const positive = path.resolve('fixtures/eslintignore/foo.js');
+	const negative = path.resolve('fixtures/eslintignore/bar.js');
+	const {results} = await fn.lintFiles(glob, {cwd});
+
+	t.is(results.some(r => r.filePath === positive), true);
+	t.is(results.some(r => r.filePath === negative), false);
+});

test/lint-text.js

@@ -161,30 +161,30 @@ test('lintText() - overrides support', async t => {
 test('do not lint gitignored files if filename is given', async t => {
 	const cwd = path.join(__dirname, 'fixtures/gitignore');
 	const ignoredPath = path.resolve('fixtures/gitignore/test/foo.js');
-	const ignored = await readFile(ignoredPath, 'utf-8');
+	const ignored = await readFile(ignoredPath, 'utf8');
 	const {results} = fn.lintText(ignored, {filename: ignoredPath, cwd});
 	t.is(results[0].errorCount, 0);
 });
 
 test('lint gitignored files if filename is not given', async t => {
 	const ignoredPath = path.resolve('fixtures/gitignore/test/foo.js');
-	const ignored = await readFile(ignoredPath, 'utf-8');
+	const ignored = await readFile(ignoredPath, 'utf8');
 	const {results} = fn.lintText(ignored);
 	t.true(results[0].errorCount > 0);
 });
 
 test('do not lint gitignored files in file with negative gitignores', async t => {
 	const cwd = path.join(__dirname, 'fixtures/negative-gitignore');
 	const ignoredPath = path.resolve('fixtures/negative-gitignore/bar.js');
-	const ignored = await readFile(ignoredPath, 'utf-8');
+	const ignored = await readFile(ignoredPath, 'utf8');
 	const {results} = fn.lintText(ignored, {filename: ignoredPath, cwd});
 	t.is(results[0].errorCount, 0);
 });
 
 test('multiple negative patterns should act as positive patterns', async t => {
 	const cwd = path.join(__dirname, 'fixtures', 'gitignore-multiple-negation');
 	const filename = path.join(cwd, '!!!unicorn.js');
-	const text = await readFile(filename, 'utf-8');
+	const text = await readFile(filename, 'utf8');
 	const {results} = fn.lintText(text, {filename, cwd});
 	t.is(results[0].errorCount, 0);
 });
@@ -197,10 +197,25 @@ test('lint negatively gitignored files', async t => {
 	t.true(results[0].errorCount > 0);
 });
 
+test('do not lint eslintignored files if filename is given', async t => {
+	const cwd = path.join(__dirname, 'fixtures/eslintignore');
+	const ignoredPath = path.resolve('fixtures/eslintignore/bar.js');
+	const ignored = await readFile(ignoredPath, 'utf8');
+	const {results} = fn.lintText(ignored, {filename: ignoredPath, cwd});
+	t.is(results[0].errorCount, 0);
+});
+
+test('lint eslintignored files if filename is not given', async t => {
+	const ignoredPath = path.resolve('fixtures/eslintignore/bar.js');
+	const ignored = await readFile(ignoredPath, 'utf8');
+	const {results} = fn.lintText(ignored);
+	t.true(results[0].errorCount > 0);
+});
+
 test('enable rules based on nodeVersion', async t => {
 	const cwd = path.join(__dirname, 'fixtures', 'engines-overrides');
 	const filename = path.join(cwd, 'promise-then.js');
-	const text = await readFile(filename, 'utf-8');
+	const text = await readFile(filename, 'utf8');
 
 	let {results} = fn.lintText(text, {nodeVersion: '>=8.0.0'});
 	t.true(hasRule(results, 'promise/prefer-await-to-then'));
@@ -212,7 +227,7 @@ test('enable rules based on nodeVersion', async t => {
 test('enable rules based on nodeVersion in override', async t => {
 	const cwd = path.join(__dirname, 'fixtures', 'engines-overrides');
 	const filename = path.join(cwd, 'promise-then.js');
-	const text = await readFile(filename, 'utf-8');
+	const text = await readFile(filename, 'utf8');
 
 	let {results} = fn.lintText(text, {
 		nodeVersion: '>=8.0.0',