Fix indent-binary-ops configuration for spaces (#825)

Author: LitoMore

lib/xo-to-eslint.ts

@@ -62,10 +62,12 @@ export function xoToEslintConfig(flatXoConfig: XoConfigItem[] | undefined, {pret
 				// eslint-disable-next-line @typescript-eslint/naming-convention
 				{SwitchCase: 1},
 			];
+			eslintConfigItem.rules['@stylistic/indent-binary-ops'] = ['error', spaces];
 		} else if (xoConfigItem.space === false) {
 			// If a user sets this to false for a small subset of files for some reason,
 			// then we need to set them back to their original values.
 			eslintConfigItem.rules['@stylistic/indent'] = configXoTypescript[1]?.rules?.['@stylistic/indent'];
+			eslintConfigItem.rules['@stylistic/indent-binary-ops'] = configXoTypescript[1]?.rules?.['@stylistic/indent-binary-ops'];
 		}
 
 		if (xoConfigItem.react) {

test/xo-to-eslint.test.ts

@@ -24,6 +24,7 @@ test('base config rules', t => {
 		// eslint-disable-next-line @typescript-eslint/naming-convention
 		{SwitchCase: 1},
 	]);
+	t.deepEqual(getJsRule(flatConfig, '@stylistic/indent-binary-ops'), ['error', 'tab']);
 	t.deepEqual(getJsRule(flatConfig, '@stylistic/semi'), ['error', 'always']);
 	t.deepEqual(getJsRule(flatConfig, '@stylistic/quotes'), ['error', 'single']);
 });
@@ -37,6 +38,7 @@ test('empty config rules', t => {
 		// eslint-disable-next-line @typescript-eslint/naming-convention
 		{SwitchCase: 1},
 	]);
+	t.deepEqual(getJsRule(flatConfig, '@stylistic/indent-binary-ops'), ['error', 'tab']);
 	t.deepEqual(getJsRule(flatConfig, '@stylistic/semi'), ['error', 'always']);
 	t.deepEqual(getJsRule(flatConfig, '@stylistic/quotes'), ['error', 'single']);
 });
@@ -50,6 +52,7 @@ test('config with space option', t => {
 		// eslint-disable-next-line @typescript-eslint/naming-convention
 		{SwitchCase: 1},
 	]);
+	t.deepEqual(getJsRule(flatConfig, '@stylistic/indent-binary-ops'), ['error', 2]);
 });
 
 test('config with semi false option', t => {

test/xo/lint-files.test.ts

@@ -114,13 +114,18 @@ test('flat config > js > space', async t => {
 		dedent`
 			export function foo() {
 				console.log('hello');
-			}\n
+			}
+
+			console.log('hello'
+				+ 'world');\n
 		`,
 	);
 	const {results} = await xo.lintFiles();
-	t.is(results?.[0]?.messages.length, 1);
+	t.is(results?.[0]?.messages.length, 2);
 	t.is(results?.[0]?.messages?.[0]?.messageId, 'wrongIndentation');
 	t.is(results?.[0]?.messages?.[0]?.ruleId, '@stylistic/indent');
+	t.is(results?.[0]?.messages?.[1]?.messageId, 'wrongIndentation');
+	t.is(results?.[0]?.messages?.[1]?.ruleId, '@stylistic/indent-binary-ops');
 });
 
 test('flat config > ts > space', async t => {
@@ -144,11 +149,16 @@ test('flat config > ts > space', async t => {
 		dedent`
 			export function foo() {
 				console.log('hello');
-			}\n
+			}
+
+			console.log('hello'
+				+ 'world');\n
 		`,
 	);
 	const {results} = await xo.lintFiles();
-	t.is(results?.[0]?.messages.length, 1);
+	t.is(results?.[0]?.messages.length, 2);
 	t.is(results?.[0]?.messages?.[0]?.messageId, 'wrongIndentation');
 	t.is(results?.[0]?.messages?.[0]?.ruleId, '@stylistic/indent');
+	t.is(results?.[0]?.messages?.[1]?.messageId, 'wrongIndentation');
+	t.is(results?.[0]?.messages?.[1]?.ruleId, '@stylistic/indent-binary-ops');
 });